Fix namebreak and add additional unit tests #710
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix namebreak and add additional unit tests
Description/Motivation/Screenshots
fix #707
Using
parse_address
, when the user already specified a direct address like*0x40600
will result in dereferencing the address instead of just passing it toBreakpoint
.This patch replaces the default value for address, if none is given, with
*$pc
instead of$pc
and removes parsing of the address completely, since user input will already be in the correct format forBreakpoint
.This way
nb
behaves more like defaultb
command againKudos to @theguy147 for adding unit tests on
namebreak
. Added some additional tests, which will also check for direct address breakpoints.How Has This Been Tested?
make test
Checklist
dev
branch, notmaster
.