-
-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow tests to be run in other places than /tmp #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugsy
requested changes
Oct 2, 2021
Co-authored-by: hugsy <hugsy@users.noreply.github.com>
hugsy
approved these changes
Oct 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty awesome
Grazfather
approved these changes
Oct 8, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: allow tests to be run in other places than /tmp
Description/Motivation/Screenshots
Today I tested
GEF
on a non-rooted Android device and had to manually make quite some changes to have the tests run because I didn't have access to thetmp/
filesystem.This PR allows changing the defaults for
TMPDIR
(where the binaries are compiled to and used for the tests and wheretrace-run
saves the traces while testing) by setting an environment variable for easier testing in different environments.Changes:
TMPDIR
by using an environment variable of the same name instead of having hard coded paths for testing (default is still/tmp
as before).gef.py
toTMPDIR
but leave it in-place for testing (because there doesn't seem to be a need to copy it over)GEF_PATH
by using an environment variable to use quickly switch between differentgef.py
versions without VCS (useful for automated testing of differentGEF
versions).PHONY
nowTMPDIR
if it doesn't existtest
target inMakefile
so e.g. the binaries don't need to be rebuild between every test run (instead introduce separateclean
target).make TestGefCommandsUnit
(capitalized)make test_cmd_elf_info
(specifically that one test) ormake test_cmd_heap_
(every test starting with "test_cmd_heap")EDIT:
DEBUG
environment variable:DEBUG=1 make test
get_shellcode()
now saves the downloaded shellcode togef.tempdir
instead of a hardcoded/tmp
How Has This Been Tested?
make test
Checklist
dev
branch, notmaster
.