Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a max() call on None in print_guessed_arguments #742

Merged
merged 1 commit into from
Oct 13, 2021
Merged

fix a max() call on None in print_guessed_arguments #742

merged 1 commit into from
Oct 13, 2021

Conversation

mahaloz
Copy link
Contributor

@mahaloz mahaloz commented Oct 13, 2021 •
edited
Loading

fix a max() call on None in print_guessed_arguments

Description/Motivation/Screenshots

There is a bug in print_guessed_arguments, line 8048. If the set is empty, no iteration happens and max gets called on None. Attached is a binary (x86_64), and a gdb script to trigger the crash.

poc.zip

How Has This Been Tested?

Architecture Yes/No Comments
x86-32 ✖️
x86-64 ✔️
ARM ✖️
AARCH64 ✖️
MIPS ✖️
POWERPC ✖️
SPARC ✖️
RISC-V ✖️
make test ✖️

Checklist

  • My PR was done against the dev branch, not master.
  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • My change adds tests as appropriate.
  • I have read and agree to the CONTRIBUTING document.

daniellimws
daniellimws approved these changes Oct 13, 2021
View reviewed changes
Copy link
Collaborator

@daniellimws daniellimws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

hugsy
hugsy approved these changes Oct 13, 2021
View reviewed changes
Copy link
Owner

@hugsy hugsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugsy hugsy merged commit 8719457 into hugsy:dev Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theguy147 theguy147 theguy147 approved these changes

@daniellimws daniellimws daniellimws approved these changes

@hugsy hugsy hugsy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mahaloz @hugsy @daniellimws @theguy147