Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Added linting for markdown files #977

Merged
merged 11 commits into from
Aug 2, 2023
Merged

[Docs] Added linting for markdown files #977

merged 11 commits into from
Aug 2, 2023

Conversation

hugsy
Copy link
Owner

@hugsy hugsy commented Jul 31, 2023

Description/Motivation/Screenshots

Applied markdownlint to docs/

Against which architecture was this tested ?

N/A

Checklist

  • My PR was done against the dev branch, not main.
  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

@hugsy hugsy added this to the 2023.08 milestone Jul 31, 2023
@hugsy hugsy requested a review from Grazfather July 31, 2023 16:14
@github-actions
Copy link

🤖 Coverage Update

  • Commit: 857c3ff
  • Current Coverage: 71.5684%
  • New Coverage: 71.5684%
  • Diff: 0.0

Repository owner deleted a comment from github-actions bot Jul 31, 2023
@hugsy hugsy changed the base branch from dev to minor_doc_additions July 31, 2023 16:20
@github-actions
Copy link

🤖 Coverage Update

  • Commit: 6684d1b
  • Current Coverage: 71.5684%
  • New Coverage: 71.5684%
  • Diff: 0.0

docs/commands/name-break.md Show resolved Hide resolved
gef➤ skipi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idk why tabs were ever here. Probably just want a space

docs/index.md Outdated Show resolved Hide resolved
docs/.markdownlint.yaml Outdated Show resolved Hide resolved
# Number of characters for code blocks
code_block_line_length: 100
# Include code blocks
code_blocks: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably want this to be false

Base automatically changed from minor_doc_additions to dev August 1, 2023 03:09
docs/api.md Outdated Show resolved Hide resolved
docs/commands/nop.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Grazfather Grazfather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint rules look good. Some of our old examples with the gef prompt seem to have tabs in them and the linter spaced them out weirdly.

docs/install.md Outdated Show resolved Hide resolved
docs/api.md Outdated Show resolved Hide resolved
docs/commands/dereference.md Outdated Show resolved Hide resolved
docs/commands/nop.md Outdated Show resolved Hide resolved
docs/commands/nop.md Outdated Show resolved Hide resolved
docs/commands/nop.md Outdated Show resolved Hide resolved
docs/commands/nop.md Outdated Show resolved Hide resolved
docs/commands/nop.md Outdated Show resolved Hide resolved
docs/commands/nop.md Outdated Show resolved Hide resolved
@Grazfather
Copy link
Collaborator

Looks good!

@hugsy hugsy merged commit 5e23739 into dev Aug 2, 2023
3 checks passed
@hugsy hugsy deleted the docs_linting branch August 2, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants