revert old thread order logic #988
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarryStokes
reviewed
Aug 15, 2023
BarryStokes
reviewed
Aug 15, 2023
therealdreg
changed the title
|
#989 is for registers, this is for threads. |
done |
Grazfather
requested changes
Aug 15, 2023
| valid_tids.add(tid) | ||
| else: | ||
| err(f"Unknown thread {tid}") | ||
| return list(valid_tids) |
There was a problem hiding this comment.
this doesn't even fix the issue, since you are adding to a set.
| try: | ||
| tid = int(tid) | ||
| except ValueError: | ||
| err(f"Invalid thread id {tid:d}") |
There was a problem hiding this comment.
:d would presumably fail since int(tid) failed. Why do we even have to do this?
There was a problem hiding this comment.
I dont know, I am just reverting to old logic xD
There was a problem hiding this comment.
Please don't just blindly revert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
revert old thread order logic
Checklist