Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add forbidden words checks to coverage action #991

Merged
merged 7 commits into from
Aug 16, 2023

Conversation

therealdreg
Copy link
Collaborator

Description

add forbidden words checks to coverage action

Checklist

  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

@github-actions
Copy link

🤖 Coverage Update

  • Commit: 49d7c12
  • Current Coverage: 71.5585%
  • New Coverage: 71.5585%
  • Diff: 0.0

To this point, this PR:

  • does not include changes to tests
  • does not include changes to documentation

@therealdreg therealdreg requested a review from hugsy August 16, 2023 03:19
.github/workflows/coverage.yml Outdated Show resolved Hide resolved
@github-actions
Copy link

🤖 Coverage Update

  • Commit: 5ef1037
  • Current Coverage: 71.5585%
  • New Coverage: 71.5585%
  • Diff: 0.0

To this point, this PR:

  • does not include changes to tests
  • does not include changes to documentation

Copy link
Owner

@hugsy hugsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change

.github/workflows/coverage.yml Outdated Show resolved Hide resolved
@github-actions
Copy link

🤖 Coverage Update

  • Commit: b984ef3
  • Current Coverage: 71.5585%
  • New Coverage: 71.5585%
  • Diff: 0.0

To this point, this PR:

  • does not include changes to tests
  • does not include changes to documentation
  • includes the forbidden words:${process.env.WORDS_FOUND}

@therealdreg therealdreg requested a review from hugsy August 16, 2023 04:38
@github-actions
Copy link

🤖 Coverage Update

  • Commit: 4f16710
  • Current Coverage: 71.5585%
  • New Coverage: 71.5585%
  • Diff: 0.0

To this point, this PR:

  • does not include changes to tests
  • does not include changes to documentation
  • does not include forbidden words

@therealdreg
Copy link
Collaborator Author

Now works as expected (manual tests):

image

Copy link
Owner

@hugsy hugsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when CI validation passes

@github-actions
Copy link

🤖 Coverage Update

  • Commit: f99b386
  • Current Coverage: 71.5585%
  • New Coverage: 71.5585%
  • Diff: 0.0

To this point, this PR:

  • does not include changes to tests
  • does not include changes to documentation
  • does not include forbidden words

@therealdreg therealdreg requested a review from hugsy August 16, 2023 08:11
@github-actions
Copy link

🤖 Coverage Update

  • Commit: adf01a1
  • Current Coverage: 71.5585%
  • New Coverage: 71.5585%
  • Diff: 0.0

To this point, this PR:

  • does not include changes to tests
  • does not include changes to documentation
  • does not include forbidden words

@therealdreg
Copy link
Collaborator Author

LGTM when CI validation passes

done

Copy link
Owner

@hugsy hugsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A+

@hugsy hugsy merged commit 371f273 into main Aug 16, 2023
5 checks passed
@hugsy hugsy deleted the therealdreg-forbidden-words-pr branch August 16, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants