Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context regs regression that broke reg order #993

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Conversation

Grazfather
Copy link
Collaborator

Description

Fixes a bug I added in #972 which lost the order of registers
fixes #986

Checklist

  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

@github-actions
Copy link

🤖 Coverage Update

  • Commit: 59b31e4
  • Current Coverage: 71.5585%
  • New Coverage: 71.5741%
  • Diff: 0.015600000000006276

To this point, this PR:

  • does not include changes to tests
  • does not include changes to documentation

@github-actions
Copy link

🤖 Coverage Update

  • Commit: 67c363d
  • Current Coverage: 71.5585%
  • New Coverage: 71.5585%
  • Diff: 0.0

To this point, this PR:

  • does not include changes to tests
  • does not include changes to documentation
  • does not include forbidden words

@github-actions
Copy link

🤖 Coverage Update

  • Commit: 9841c43
  • Current Coverage: 71.5585%
  • New Coverage: 71.5741%
  • Diff: 0.015600000000006276

To this point, this PR:

  • does not include changes to tests
  • does not include changes to documentation
  • does not include forbidden words

Copy link
Owner

@hugsy hugsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hugsy hugsy merged commit 9f79363 into main Aug 16, 2023
6 checks passed
@hugsy hugsy deleted the fix_reg_order branch August 16, 2023 16:55
@hugsy hugsy added this to the 2024.01 milestone Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Changes made in commit #81ee52d mean that register order is no longer maintained in context
2 participants