Fix gdb.execute not quoting paths #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Coverage Update
To this point, this PR:
|
Grazfather
force-pushed
the
fix_gdb_execute_paths
branch
from
bfec296
to
be6ea9d
Compare
🤖 Coverage Update
To this point, this PR:
|
Grazfather
force-pushed
the
fix_gdb_execute_paths
branch
from
be6ea9d
to
b989829
Compare
🤖 Coverage Update
To this point, this PR:
|
🤖 Coverage Update
To this point, this PR:
|
🤖 Coverage Update
To this point, this PR:
|
🤖 Coverage Update
To this point, this PR:
|
4 tasks
hugsy
reviewed
Aug 26, 2023
Grazfather
force-pushed
the
fix_gdb_execute_paths
branch
from
a0e8af9
to
0473b0c
Compare
🤖 Coverage Update
To this point, this PR:
|
🤖 Coverage Update
To this point, this PR:
|
🤖 Coverage Update
To this point, this PR:
|
🤖 Coverage Update
To this point, this PR:
|
hugsy
pushed a commit
that referenced
this pull request
Aug 26, 2023
This change makes it so that write hooks see the actual value provided to a setting when `gef config` is used, and gives it the chance to raise an exception if the value is invalid. It also adds a validator 'no_spaces' and adds it to a few settings that use filepaths, since we know (from #999) that some GDB commands completely break when paths have spaces and/or when paths are quotes.
Grazfather
force-pushed
the
fix_gdb_execute_paths
branch
from
0473b0c
to
45c7dac
Compare
🤖 Coverage Update
To this point, this PR:
|
🤖 Coverage Update
To this point, this PR:
|
hugsy
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As I looked into #901, I found that we often don't quote filepaths in
gdb.execute. This began lazy grep that tries to ID where we do this, and fixes where we can. Noticed that we cannot use quotes in the filename when setting up logging, so it instead restricts the logging path to one without spaces.This is mostly untested.
Checklist