Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling on mobile does not have a momentum #22

Closed
michalsnik opened this issue Apr 28, 2016 · 3 comments
Closed

Scrolling on mobile does not have a momentum #22

michalsnik opened this issue Apr 28, 2016 · 3 comments

Comments

@michalsnik
Copy link

michalsnik commented Apr 28, 2016

Scrolling on mobile devices should have a momentum.
In order to achieve so .modaal-wrapper should have:

overflow-y: scroll;
webkit-overflow-scrolling: touch;

Short article about this: https://css-tricks.com/snippets/css/momentum-scrolling-on-ios-overflow-elements/

I'm going to make a PR later.

@michalsnik michalsnik changed the title Scroll on mobile does not have a momentum Scrolling on mobile does not have a momentum Apr 28, 2016
@cbotman
Copy link
Contributor

cbotman commented Apr 29, 2016

Hi @michalsnik, thanks for flagging this. I quickly tried to implement the solution you described and it didn't work, but I think because of another issue. On my iPhone 6 for example, Modaal isn't trapping focus and the background page is scrolling instead. I suspect when that is fixed, your update will also work.

Edit: Ah, there's a background_scroll option for Modaal which defaults to false, so what I described is not necessarily a bug, but I think it still relates to the momentum scrolling issue. Will investigate further.

@danhumaan
Copy link
Collaborator

Hi @michalsnik, thanks again for your contribution. A fix has been just been rolled out in the latest release for this issue.

@michalsnik
Copy link
Author

Hi @danb-humaan , good work! 👍

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants