Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no need of the kubernetes provider #3

Merged
merged 2 commits into from
Feb 2, 2024
Merged

no need of the kubernetes provider #3

merged 2 commits into from
Feb 2, 2024

Conversation

mathieu-benoit
Copy link
Contributor

Because we now use an Azure IP address resource and for simplification, no need of the kubernetes provider.

@mathieu-benoit mathieu-benoit requested a review from a team as a code owner February 2, 2024 12:14
johanneswuerbach
johanneswuerbach approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@johanneswuerbach johanneswuerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing a make docs, but otherwise 👍

@mathieu-benoit mathieu-benoit merged commit 1aa24e9 into main Feb 2, 2024
1 check passed
@mathieu-benoit mathieu-benoit deleted the no-kubernetes-provider branch February 2, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanneswuerbach johanneswuerbach johanneswuerbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathieu-benoit @johanneswuerbach