Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling for db updates #89

Merged
merged 1 commit into from
Jun 5, 2017
Merged

Better handling for db updates #89

merged 1 commit into from
Jun 5, 2017

Conversation

roborourke
Copy link
Contributor

fix db index size error, varchar max is now 191, also add utf8mb4 conversion

Fixes #68

@roborourke roborourke requested a review from rmccue June 5, 2017 13:00
mattheu
mattheu approved these changes Jun 5, 2017
View reviewed changes
Copy link
Member

@mattheu mattheu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@roborourke roborourke merged commit 671f147 into master Jun 5, 2017
@roborourke roborourke deleted the db-updates branch June 5, 2017 13:08
@roborourke roborourke restored the db-updates branch June 5, 2017 13:12
@roborourke roborourke deleted the db-updates branch June 5, 2017 13:34
@roborourke roborourke mentioned this pull request Oct 31, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattheu mattheu mattheu approved these changes

@rmccue rmccue Awaiting requested review from rmccue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ERROR 1709 (HY000): Index column size too large. The maximum column size is 767 bytes.
2 participants
@roborourke @mattheu