-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes routes on sites in subfolders #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a couple of notes - the slash handling can be improved a bit because I didn't do a great job of it the first time around!
Restsplain.php
Outdated
if ( get_query_var( 'restsplain', false ) ) { | ||
return get_default_docs_base(); | ||
return $subdir_install . get_default_docs_base(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Realised that get_default_docs_base()
should probably check it starts with a slash 🤔 Don't worry about that for this PR, just a note to myself.
Co-authored-by: Robert O'Rourke <rob@humanmade.com>
Co-authored-by: Robert O'Rourke <rob@humanmade.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one 😄
Fixes #23
Testing instructions
Check #23 for more details