Fix bug on mime-type of uploaded files #126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a workaround for what I consider 2 bugs in wp_import_handle_upload() that limit impede the UX of this plugin:
See Issue 125: incorrect mime-type on uploaded WXR documents.
Note: this workaround should be considered temporary and reverted once/if the bugs are fixed in core.
Note: this PR needs to be merged before the one in Fix bug whereby non-xml files in the media library are shown when "Select it from the Media Library" is clicked otherwise that other PR will result in any files uploaded by this plugin to not show up in the media modal dialog. Sorry, I should have submitted this one 1st to avoid the confusion.