Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xml reader: don't block attempt to read from stdin using wxr-importer import php://stdin #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drzraf
Copy link

@drzraf drzraf commented Aug 21, 2017

No description provided.

@rmccue
Copy link
Member

rmccue commented Aug 21, 2017

To fit better with how CLI apps generally work, you should pass - instead, and we should handle that if we don't already.

@drzraf
Copy link
Author

drzraf commented Aug 21, 2017

addressed

@drzraf
Copy link
Author

drzraf commented Aug 22, 2017

side note:
If this can be merged : wp-cli/export-command#9 ...
then it'd be possible to test transformation identity (admitting an --override flag would exist) by checking that such an operation...
$ wp export --stdout | wp wxr-importer import --override -
... implied no change on the source database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants