Add admin UI #26
Merged
Add admin UI #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Known bugs:
|
This ensures we don't try to incorrectly map authors.
wp_handle_import_upload() sets status to private, which is one of the only things we can query by. We could also query by _wp_attachment_context, but the JS won't let us send that.
This is added as an action, but refers to media-new.php directly, so doesn't make sense outside of that.
|
|
| }; | ||
|
|
||
| // init and set the uploader | ||
| uploader_init = function() { |
There was a problem hiding this comment.
Can't see where this var is declared unless it's a global scope thing.
| jQuery('#import-log').append( row ); | ||
| }); | ||
| </script> | ||
| <style> |
There was a problem hiding this comment.
Any way this can go into a CSS file or head action? Not technically valid inside <body>
There was a problem hiding this comment.
Oops, meant to move the CSS & JS into separate files. Will-do.
|
|
||
| <h3><?php esc_html_e( 'Assign Authors', 'wordpress-importer' ) ?></h3> | ||
| <p><?php echo wp_kses( | ||
| __( 'To make it easier for you to edit and save the imported content, you may want to reassign the author of the imported item to an existing user of this site. For example, you may want to import all the entries as <code>admin</code>s entries.', 'wordpress-importer' ), |
There was a problem hiding this comment.
admin is no longer the default - could fetch username for user with ID=1? Or the first admin user for the site.
There was a problem hiding this comment.
True, though it's only an example, so I don't think it's worth bothering.
|
Merging; we can change wording and such later. :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1.