-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade tooling for WPCS 3.0 and PHP 8.0+ #60
Conversation
…pe hinting syntax
I understand pinning to versions but why pin to a specific commit of the actions? |
@@ -1,4 +1,5 @@ | |||
# Travis CI Configuration File |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still need Travis if we have a php linting action?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit tests! 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved in principle from a reading of the code, left some comments
Thank you for your support and your enthousiasm embracing the take-over of the PHP_CodeSniffer package. In contrast to earlier information, arrangements have been made to allow the package to continue under its original name on Packagist. The commit (in the new repo) to rename the package has been reverted. I'd recommend reverting the Composer reference changes and keeping the changes which refer to the repo URL on GitHub. Sorry for the confusion and thank you for understanding. I hope you'll enjoy the 3.8.0 release, which was released last month. |
href
attr on 404.html file #56