Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tooling for WPCS 3.0 and PHP 8.0+ #60

Merged
merged 13 commits into from
Dec 10, 2023
Merged

Upgrade tooling for WPCS 3.0 and PHP 8.0+ #60

merged 13 commits into from
Dec 10, 2023

Conversation

kadamwhite
Copy link
Collaborator

@kadamwhite kadamwhite changed the title Tooling upgrade Upgrade tooling for WPCS 3.0 and PHP 8.0+ Dec 8, 2023
@tomjn
Copy link
Contributor

tomjn commented Dec 10, 2023

I understand pinning to versions but why pin to a specific commit of the actions?

@@ -1,4 +1,5 @@
# Travis CI Configuration File
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need Travis if we have a php linting action?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests! 😁

Copy link
Contributor

@tomjn tomjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in principle from a reading of the code, left some comments

@kadamwhite kadamwhite merged commit 091d048 into main Dec 10, 2023
2 checks passed
@kadamwhite kadamwhite deleted the tooling-upgrade branch December 10, 2023 19:57
@jrfnl
Copy link

jrfnl commented Jan 9, 2024

Thank you for your support and your enthousiasm embracing the take-over of the PHP_CodeSniffer package.

In contrast to earlier information, arrangements have been made to allow the package to continue under its original name on Packagist. The commit (in the new repo) to rename the package has been reverted.

I'd recommend reverting the Composer reference changes and keeping the changes which refer to the repo URL on GitHub.

Sorry for the confusion and thank you for understanding. I hope you'll enjoy the 3.8.0 release, which was released last month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants