Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer.json to use PHPCS standards package #312

Closed
wants to merge 1 commit into from

Conversation

tomjn
Copy link
Contributor

@tomjn tomjn commented Dec 3, 2023

Removes the abandoned squizlabs PHPCS package and replaces it with the new PHPCS Standards org version

Removes the abandoned squizlabs PHPCS package and replaces it with the new PHPCS Standards org version
Copy link
Contributor

@roborourke roborourke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tomjn

@tomjn
Copy link
Contributor Author

tomjn commented Dec 4, 2023

I wonder if we should wait for these 2 PRs to merge before merging this:

Those PRs update those standards to use the new 3.8.0 version which we aren't using here though

@jrfnl
Copy link

jrfnl commented Dec 7, 2023

Thank you for your support and your enthousiasm embracing the take-over of the PHP_CodeSniffer package.

In contrast to earlier information, arrangements are now being made to allow the package to continue under its original name on Packagist. The commit (in the new repo) to rename the package has been reverted.

I'd recommend reverting the Composer reference changes and keeping the changes which refer to the repo URL on GitHub.

Sorry for the confusion and thank you for understanding. I hope you'll enjoy the 3.8.0 release, which I expect to release this Friday.

@rmccue
Copy link
Member

rmccue commented Feb 21, 2024

Let's close this out since phpcs is back :D

@rmccue rmccue closed this Feb 21, 2024
@jrfnl
Copy link

jrfnl commented Feb 21, 2024

Let's close this out since phpcs is back :D

It was never gone ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants