Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

101 - Fix date label not being cleared when both selected dates are unset #102

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

Rayhatron
Copy link
Contributor

@Rayhatron Rayhatron commented Dec 2, 2021

#101

There is a bug where the label above the "Edit date filter" button isn't cleared after unsetting dates. Steps to reproduce:

  • Click "Edit date filter" button
  • Select a date in both date pickers
  • Click "Confirm" button
  • The label above the "Edit date filter" button should show text that has the two selected dates
  • Click "Edit date filter" button again
  • Click the two "Unset" buttons for the date pickers
  • Click "Confirm" button
  • The label above the "Edit date filter" will remain but this shouldn't be the case

Acceptance criteria

  • The final result of repeating the steps mentioned above should be the label above the "Edit date filter" button will be cleared.

@Rayhatron Rayhatron changed the title Fix date label not being cleared when both selected dates are unset 101 - Fix date label not being cleared when both selected dates are unset Dec 2, 2021
@Rayhatron Rayhatron self-assigned this Dec 2, 2021
@Rayhatron Rayhatron linked an issue Dec 2, 2021 that may be closed by this pull request
1 task
@Rayhatron Rayhatron merged commit 234b981 into main Dec 2, 2021
@Rayhatron Rayhatron deleted the 101-fix-uncleared-date-label branch December 2, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: persistant date label after unsetting dates
2 participants