Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move AccountProvider interface into fp-em #71

Merged
merged 4 commits into from
Jun 18, 2023
Merged

Move AccountProvider interface into fp-em #71

merged 4 commits into from
Jun 18, 2023

Conversation

dmitrylavrenov
Copy link

No description provided.

@dmitrylavrenov dmitrylavrenov requested a review from MOZGIII June 16, 2023 13:29
MOZGIII
MOZGIII reviewed Jun 17, 2023
View reviewed changes
frame/evm/src/lib.rs Outdated Show resolved Hide resolved
MOZGIII
MOZGIII reviewed Jun 17, 2023
View reviewed changes
primitives/evm/Cargo.toml Outdated Show resolved Hide resolved
MOZGIII
MOZGIII approved these changes Jun 17, 2023
View reviewed changes
Copy link

@MOZGIII MOZGIII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we revert the changes to mere formatting? They clutter the diff. If we need them, let's land them as a separate PR prior to this one, as I'm sure they can be applied automatically.

MOZGIII
MOZGIII requested changes Jun 17, 2023
View reviewed changes
Copy link

@MOZGIII MOZGIII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to ask for changes above

@dmitrylavrenov dmitrylavrenov force-pushed the fp-evm-account-provider branch 5 times, most recently from e0771af to a82ae21 Compare June 18, 2023 08:17
@dmitrylavrenov dmitrylavrenov force-pushed the fp-evm-account-provider branch 2 times, most recently from 8b65986 to 99210c7 Compare June 18, 2023 08:23
@dmitrylavrenov dmitrylavrenov force-pushed the fp-evm-account-provider branch from 99210c7 to db3c4af Compare June 18, 2023 08:27
@dmitrylavrenov
Copy link
Author

Can we revert the changes to mere formatting? They clutter the diff. If we need them, let's land them as a separate PR prior to this one, as I'm sure they can be applied automatically.

Formatter changes have been reverted.

@dmitrylavrenov dmitrylavrenov requested a review from MOZGIII June 18, 2023 08:30
@dmitrylavrenov dmitrylavrenov merged commit 14bc752 into locked/polkadot-v0.9.38 Jun 18, 2023
@dmitrylavrenov dmitrylavrenov deleted the fp-evm-account-provider branch June 18, 2023 08:34
@dmitrylavrenov dmitrylavrenov mentioned this pull request Jun 22, 2023
Closed
32 tasks
dmitrylavrenov added a commit that referenced this pull request Oct 12, 2023
@dmitrylavrenov
Move AccountProvider interface into fp-em (#71)
da85216 
* Move account provider interface into fp-em

* Implement AccountProvider interface for EvmSystem

* Revert formatter

* Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov added a commit that referenced this pull request Oct 12, 2023
@dmitrylavrenov
Move AccountProvider interface into fp-em (#71)
e02f186 
* Move account provider interface into fp-em

* Implement AccountProvider interface for EvmSystem

* Revert formatter

* Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov added a commit that referenced this pull request Oct 12, 2023
@dmitrylavrenov
Move AccountProvider interface into fp-em (#71)
a23c2ab 
* Move account provider interface into fp-em

* Implement AccountProvider interface for EvmSystem

* Revert formatter

* Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov added a commit that referenced this pull request Oct 12, 2023
@dmitrylavrenov
Move AccountProvider interface into fp-em (#71)
507a9e1 
* Move account provider interface into fp-em

* Implement AccountProvider interface for EvmSystem

* Revert formatter

* Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov added a commit that referenced this pull request Oct 19, 2023
@dmitrylavrenov
Support external account provider (#75)
d3b3786 
* Introduce external account provider into `pallet_evm` (#61)

* Introduce AccountProvider interface

* Apply account provider logic for tests and template

* Fix docs for remove_account method

* Fix missing docs

* Improve docs for account provider trait

* Fix docs for native system account provider

* Move account provider logic to separate mod

* Add details docs for methods

* Move `AccountProvider` interface into `fp-em` (#71)

* Move account provider interface into fp-em

* Implement AccountProvider interface for EvmSystem

* Revert formatter

* Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov added a commit that referenced this pull request Oct 31, 2023
@dmitrylavrenov
Move AccountProvider interface into fp-em (#71)
d2138c7 
* Move account provider interface into fp-em

* Implement AccountProvider interface for EvmSystem

* Revert formatter

* Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov added a commit that referenced this pull request Oct 31, 2023
@dmitrylavrenov
Move AccountProvider interface into fp-em (#71)
ab32f57 
* Move account provider interface into fp-em

* Implement AccountProvider interface for EvmSystem

* Revert formatter

* Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov added a commit that referenced this pull request Oct 31, 2023
@dmitrylavrenov
Support external account provider (#83)
37ddc20 
* Introduce external account provider into `pallet_evm` (#61)

* Introduce AccountProvider interface

* Apply account provider logic for tests and template

* Fix docs for remove_account method

* Fix missing docs

* Improve docs for account provider trait

* Fix docs for native system account provider

* Move account provider logic to separate mod

* Add details docs for methods

* Move `AccountProvider` interface into `fp-em` (#71)

* Move account provider interface into fp-em

* Implement AccountProvider interface for EvmSystem

* Revert formatter

* Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov added a commit that referenced this pull request Nov 22, 2023
@dmitrylavrenov
Support external account provider (#83)
2792dc0 
* Introduce external account provider into `pallet_evm` (#61)

* Introduce AccountProvider interface

* Apply account provider logic for tests and template

* Fix docs for remove_account method

* Fix missing docs

* Improve docs for account provider trait

* Fix docs for native system account provider

* Move account provider logic to separate mod

* Add details docs for methods

* Move `AccountProvider` interface into `fp-em` (#71)

* Move account provider interface into fp-em

* Implement AccountProvider interface for EvmSystem

* Revert formatter

* Move NativeSystemAccountProvider to pallet-evm
@dmitrylavrenov dmitrylavrenov mentioned this pull request Nov 22, 2023
Merged
dmitrylavrenov added a commit that referenced this pull request Nov 22, 2023
@dmitrylavrenov
Support external account provider (#83) (#92)
55f5321 
* Introduce external account provider into `pallet_evm` (#61)

* Introduce AccountProvider interface

* Apply account provider logic for tests and template

* Fix docs for remove_account method

* Fix missing docs

* Improve docs for account provider trait

* Fix docs for native system account provider

* Move account provider logic to separate mod

* Add details docs for methods

* Move `AccountProvider` interface into `fp-em` (#71)

* Move account provider interface into fp-em

* Implement AccountProvider interface for EvmSystem

* Revert formatter

* Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov added a commit that referenced this pull request Dec 19, 2023
@dmitrylavrenov
Support external account provider (#83) (#92)
4dcc370 
* Introduce external account provider into `pallet_evm` (#61)

* Introduce AccountProvider interface

* Apply account provider logic for tests and template

* Fix docs for remove_account method

* Fix missing docs

* Improve docs for account provider trait

* Fix docs for native system account provider

* Move account provider logic to separate mod

* Add details docs for methods

* Move `AccountProvider` interface into `fp-em` (#71)

* Move account provider interface into fp-em

* Implement AccountProvider interface for EvmSystem

* Revert formatter

* Move NativeSystemAccountProvider to pallet-evm
@dmitrylavrenov dmitrylavrenov mentioned this pull request Dec 19, 2023
Merged
dmitrylavrenov added a commit that referenced this pull request Dec 19, 2023
@dmitrylavrenov
Support external account provider (#83) (#92)
58e970d 
* Introduce external account provider into `pallet_evm` (#61)

* Introduce AccountProvider interface

* Apply account provider logic for tests and template

* Fix docs for remove_account method

* Fix missing docs

* Improve docs for account provider trait

* Fix docs for native system account provider

* Move account provider logic to separate mod

* Add details docs for methods

* Move `AccountProvider` interface into `fp-em` (#71)

* Move account provider interface into fp-em

* Implement AccountProvider interface for EvmSystem

* Revert formatter

* Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov added a commit that referenced this pull request Dec 19, 2023
@dmitrylavrenov
Support external account provider (#83) (#92) (#97)
1a6cab8 
* Introduce external account provider into `pallet_evm` (#61)

* Introduce AccountProvider interface

* Apply account provider logic for tests and template

* Fix docs for remove_account method

* Fix missing docs

* Improve docs for account provider trait

* Fix docs for native system account provider

* Move account provider logic to separate mod

* Add details docs for methods

* Move `AccountProvider` interface into `fp-em` (#71)

* Move account provider interface into fp-em

* Implement AccountProvider interface for EvmSystem

* Revert formatter

* Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov added a commit that referenced this pull request Feb 19, 2024
@dmitrylavrenov
Support external account provider (#83) (#92) (#97)
1026677 
* Introduce external account provider into `pallet_evm` (#61)

* Introduce AccountProvider interface

* Apply account provider logic for tests and template

* Fix docs for remove_account method

* Fix missing docs

* Improve docs for account provider trait

* Fix docs for native system account provider

* Move account provider logic to separate mod

* Add details docs for methods

* Move `AccountProvider` interface into `fp-em` (#71)

* Move account provider interface into fp-em

* Implement AccountProvider interface for EvmSystem

* Revert formatter

* Move NativeSystemAccountProvider to pallet-evm
@dmitrylavrenov dmitrylavrenov mentioned this pull request Feb 19, 2024
Merged
dmitrylavrenov added a commit that referenced this pull request Feb 19, 2024
@dmitrylavrenov
Support external account provider (#83) (#92) (#97) (#104)
64b91bf 
* Introduce external account provider into `pallet_evm` (#61)

* Introduce AccountProvider interface

* Apply account provider logic for tests and template

* Fix docs for remove_account method

* Fix missing docs

* Improve docs for account provider trait

* Fix docs for native system account provider

* Move account provider logic to separate mod

* Add details docs for methods

* Move `AccountProvider` interface into `fp-em` (#71)

* Move account provider interface into fp-em

* Implement AccountProvider interface for EvmSystem

* Revert formatter

* Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov added a commit that referenced this pull request Mar 6, 2024
@dmitrylavrenov
Support external account provider (#83) (#92) (#97)
f2f57b1 
* Introduce external account provider into `pallet_evm` (#61)

* Introduce AccountProvider interface

* Apply account provider logic for tests and template

* Fix docs for remove_account method

* Fix missing docs

* Improve docs for account provider trait

* Fix docs for native system account provider

* Move account provider logic to separate mod

* Add details docs for methods

* Move `AccountProvider` interface into `fp-em` (#71)

* Move account provider interface into fp-em

* Implement AccountProvider interface for EvmSystem

* Revert formatter

* Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov added a commit that referenced this pull request Jun 10, 2024
@dmitrylavrenov
Support external account provider (#83) (#92) (#97) (#104)
b0e5d5d 
* Introduce external account provider into `pallet_evm` (#61)

* Introduce AccountProvider interface

* Apply account provider logic for tests and template

* Fix docs for remove_account method

* Fix missing docs

* Improve docs for account provider trait

* Fix docs for native system account provider

* Move account provider logic to separate mod

* Add details docs for methods

* Move `AccountProvider` interface into `fp-em` (#71)

* Move account provider interface into fp-em

* Implement AccountProvider interface for EvmSystem

* Revert formatter

* Move NativeSystemAccountProvider to pallet-evm
@dmitrylavrenov dmitrylavrenov mentioned this pull request Jun 10, 2024
Merged
dmitrylavrenov added a commit that referenced this pull request Jun 10, 2024
@dmitrylavrenov
Support external account provider (#83) (#92) (#97) (#104) (#121)
ee14c57 
* Introduce external account provider into `pallet_evm` (#61)

* Introduce AccountProvider interface

* Apply account provider logic for tests and template

* Fix docs for remove_account method

* Fix missing docs

* Improve docs for account provider trait

* Fix docs for native system account provider

* Move account provider logic to separate mod

* Add details docs for methods

* Move `AccountProvider` interface into `fp-em` (#71)

* Move account provider interface into fp-em

* Implement AccountProvider interface for EvmSystem

* Revert formatter

* Move NativeSystemAccountProvider to pallet-evm
dmitrylavrenov added a commit that referenced this pull request Oct 21, 2024
@dmitrylavrenov
Support external account provider (#83) (#92) (#97) (#104)
501c85a 
* Introduce external account provider into `pallet_evm` (#61)

* Introduce AccountProvider interface

* Apply account provider logic for tests and template

* Fix docs for remove_account method

* Fix missing docs

* Improve docs for account provider trait

* Fix docs for native system account provider

* Move account provider logic to separate mod

* Add details docs for methods

* Move `AccountProvider` interface into `fp-em` (#71)

* Move account provider interface into fp-em

* Implement AccountProvider interface for EvmSystem

* Revert formatter

* Move NativeSystemAccountProvider to pallet-evm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MOZGIII MOZGIII MOZGIII approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmitrylavrenov @MOZGIII