fix(types): widen too-narrow types #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boneskull
force-pushed
the
boneskull/ts-fixes
branch
3 times, most recently
from
93cea1c
to
7a2b5d7
Compare
nzakas
reviewed
Nov 1, 2023
boneskull
force-pushed
the
boneskull/ts-fixes
branch
2 times, most recently
from
db56be4
to
c5de5ff
Compare
|
@boneskull I think you still were fixing some things on this? Any other changes before we're ready to merge? |
|
@nzakas Ah, uh. Let me check. 😄 |
Since many functions accept `number`, which is then coerced to `string`, we need to account for that. `Record<string, string>` for the type of `T` _would_ be fine, except: 1. `ProcessEnv` is `Record<string, undefined>`. I'm guessing since you can write `process.env.cows = undefined`. However, everything coming out of the actual environment in `process.env` is a `string`. 2. An empty object literal is not a `Record`, but it is an `object`. So we have to loosen the type arg `T` to extend `object`.
- Renamed the existing fixture to `ts-project-module-nodenext` - Added a new fixture `ts-project-module-commonjs` which is identical except it uses the `commonjs` `module` option and thus `node` `moduleResolution`
boneskull
force-pushed
the
boneskull/ts-fixes
branch
from
c5de5ff
to
9ff838d
Compare
|
@nzakas OK, I'm done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #99 I changed stuff, but I made a mistake or two. This fixes those mistakes.
Additionally, added type coverage for tests.