Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix github actions deprecation warnings + preflight checks #12

Merged
merged 38 commits into from
Feb 10, 2024

Conversation

humbletim
Copy link
Owner

@humbletim humbletim commented Oct 23, 2022

  • update action dependencies to avoid deprecation warnings
  • add more error checking and preflight checks around SDK webservice assumptions

bump actions/cache to v3
bump actions/checkout to v2.5.0
@humbletim
Copy link
Owner Author

@humbletim humbletim self-assigned this Oct 23, 2022
@humbletim humbletim marked this pull request as ready for review October 23, 2022 20:08
@humbletim humbletim changed the title fix github actions deprecation warnings fix github actions deprecation warnings + preflight checks Oct 27, 2022
@humbletim
Copy link
Owner Author

preflight checks TODO:

  • improved detection and reporting of webservice errors (including webservice internal error message when available)
    -eg: specifying "bogus" for the SDK release number: image
  • verify config.json ducktypes as a valid Vulkan SDK config before attempting to use

@edvn0
Copy link

edvn0 commented Feb 23, 2023

Could we merge this? @humbletim

@dsvensson
Copy link

Guess a year between reminders is ok @humbletim

@kalwalt
Copy link

kalwalt commented Feb 5, 2024

Can you merge this @humbletim ?

@humbletim
Copy link
Owner Author

Hi.. I am (somewhat) back again and in any event planning to get this PR merged this week. Apologies for the delay. Also if anyone is interested in adopting lead responsibility for the project or helping to co-maintain please let me know.

@edvn0
Copy link

edvn0 commented Feb 6, 2024

Hi.. I am (somewhat) back again and in any event planning to get this PR merged this week. Apologies for the delay. Also if anyone is interested in adopting lead responsibility for the project or helping to co-maintain please let me know.

Don't worry. I could help you out 😃

@kalwalt
Copy link

kalwalt commented Feb 6, 2024

Hi.. I am (somewhat) back again and in any event planning to get this PR merged this week. Apologies for the delay. Also if anyone is interested in adopting lead responsibility for the project or helping to co-maintain please let me know.

Thank you @humbletim ! This is awesome!

README.md Outdated
- 1.3.204.1
- 1.3.211.0
- 1.3.216.0
- 1.3.224.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.3.275.0 is already out.

@humbletim
Copy link
Owner Author

Hi everyone!

There seems to be a recent issue building SPIRV-Tools on macOS. While unrelated to this PR, I typically run a final "CI build" on different platforms before releasing. Unfortunately, Mac builds are failing for all but the the latest SDK version, apparent due to sprintf-related warnings being promoted into errors by compile flags somewhere. Which for older releases should not have changed... but could have for example on LunarG webservices config.json side of the equation.

To understand the scope of the problem, I'd appreciate it if anyone using the SDK on Mac could share:

  • Which SDK version are you targeting?
  • Have you encountered any recent build failures related to sprintf?

I'm planning to merge this PR to "main" later tonight after one final non-mac-legacy CI test, but am thinking to hold off on stamping an official release tag until I have a clearer picture of the Mac issue. Once I gather more information, I plan to file an issue report and potentially involve relevant teams for a resolution.

Thanks for your input!

@humbletim humbletim merged commit 286ed76 into main Feb 10, 2024
29 of 35 checks passed
@humbletim humbletim mentioned this pull request Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants