Add PHP 8 support #446

smoench · 2020-11-30T09:23:19Z

Waiting for:

https://github.com/oradwell/covers-validator to be PHP 8 compatible
fix e2e_0211 - 8.0
fix e2e_027
fix e2e_028 - 7.3 (@smoench)
fix e2e_028 - 8.0 (@smoench)

smoench · 2020-11-30T16:07:54Z

@theofidry @villfa It seems e2e_020 fails with composer v2. With composer v1 it works but composer v1 is not compatible with PHP 8.0 yet. Can you have look?

composer --working-dir=fixtures/set020-infection install
 146/146 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
Package operations: 29 installs, 0 updates, 0 removals
  - Downloading infection/extension-installer (0.1.1)
  - Downloading thecodingmachine/safe (v1.3.3)
  - Downloading symfony/process (v5.2.0)
  - Downloading symfony/finder (v5.2.0)
  - Downloading symfony/filesystem (v5.2.0)
  - Downloading sanmai/pipeline (v5.1.0)
  - Downloading ondram/ci-detector (3.5.1)
  - Downloading infection/include-interceptor (0.2.4)
  - Downloading infection/abstract-testframework-adapter (0.3.1)
  - Downloading infection/infection (0.18.2)
  0/10 [>---------------------------]   0%
  1/10 [==>-------------------------]  10%
  2/10 [=====>----------------------]  20%
  3/10 [========>-------------------]  30%
  4/10 [===========>----------------]  40%
  6/10 [================>-----------]  60%
  7/10 [===================>--------]  70%
  8/10 [======================>-----]  80%
  9/10 [=========================>--]  90%
 10/10 [============================] 100%  - Installing composer/package-versions-deprecated (1.11.99.1): Extracting archive
  - Installing infection/extension-installer (0.1.1): Extracting archive
  - Installing symfony/polyfill-ctype (v1.20.0): Extracting archive
  - Installing webmozart/assert (1.9.1): Extracting archive
  - Installing webmozart/path-util (2.3.0): Extracting archive
  - Installing thecodingmachine/safe (v1.3.3): Extracting archive
  - Installing symfony/polyfill-php80 (v1.20.0): Extracting archive
  - Installing symfony/process (v5.2.0): Extracting archive
  - Installing symfony/finder (v5.2.0): Extracting archive
  - Installing symfony/filesystem (v5.2.0): Extracting archive
  - Installing symfony/polyfill-mbstring (v1.20.0): Extracting archive
  - Installing symfony/polyfill-intl-normalizer (v1.20.0): Extracting archive
  - Installing symfony/polyfill-intl-grapheme (v1.20.0): Extracting archive
  - Installing symfony/string (v5.2.0): Extracting archive
  - Installing psr/container (1.0.0): Extracting archive
  - Installing symfony/service-contracts (v2.2.0): Extracting archive
 1213/1270 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓░░]  95%
[OK] Successfully prefixed 1270 files.
// Memory usage: 21.40MB (peak: 64.68MB), time: 11.17s
composer --working-dir=build/set020-infection dump-autoload

Generating autoload files

Generated autoload files
We generate the expected output file: we test that the scoping process
does not alter it
php fixtures/set020-infection/vendor/infection/infection/bin/infection 

--coverage=dist/infection-coverage 

--skip-initial-tests 

--only-covered 

--no-progress

1270/1270 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%PHP Fatal error:  Uncaught OutOfBoundsException: Package "infection/infection" is not installed in /home/runner/work/php-scoper/php-scoper/vendor/composer/InstalledVersions.php:928

Stack trace:

#0 /home/runner/work/php-scoper/php-scoper/vendor/composer/package-versions-deprecated/src/PackageVersions/Versions.php(155): Composer\InstalledVersions::getPrettyVersion()

#1 /home/runner/work/php-scoper/php-scoper/fixtures/set020-infection/vendor/infection/infection/src/Console/Application.php(75): PackageVersions\Versions::getVersion()

#2 /home/runner/work/php-scoper/php-scoper/fixtures/set020-infection/vendor/infection/infection/bin/infection(83): Infection\Console\Application->__construct()

#3 {main}

thrown in /home/runner/work/php-scoper/php-scoper/vendor/composer/InstalledVersions.php on line 928

make: *** [e2e_020] Error 255

Makefile:204: recipe for target 'e2e_020' failed

theofidry · 2020-11-30T18:22:06Z

Hm given how easy to is to upgrade to Composer 1 I wonder if it doesn't make sense to drop it completely...

villfa · 2020-11-30T21:43:48Z

Look here:

#0 /home/runner/work/php-scoper/php-scoper/vendor/composer/package-versions-deprecated/src/PackageVersions/Versions.php(155): Composer\InstalledVersions::getPrettyVersion()

This is not the right path. Instead it should be (notice build/set020-infection/) :

/home/runner/work/php-scoper/php-scoper/build/set020-infection/vendor/composer/package-versions-deprecated/src/PackageVersions/Versions.php

I don't know more for now.

EDIT:
By replacing php fixtures/set020-infection/vendor/infection/infection/bin/infection by cd fixtures/set020-infection && php vendor/infection/infection/bin/infection it works better.

EDIT2:
I confirm that the working directory used to run Infection matters: https://github.com/infection/infection/blob/1368b12acf0e9679deb5d371edf2d5ebf3c98e34/bin/infection#L78

smoench · 2020-12-01T11:03:53Z

Thanks. Infection is running again but I'm not sure if it is correct.

smoench · 2020-12-01T14:16:22Z

I just parallelized the e2e tests in GitHub Actions 👀 (because composer v1 is not compatible with PHP 8.0)

villfa · 2020-12-01T16:03:52Z

(because composer v1 is not compatible with PHP 8.0)

FYI, it will be compatible from the next release: composer/composer#9523

.github/workflows/e2e.yml

.github/workflows/generate-e2e-matrix.php

Co-authored-by: Fabien Villepinte <fabien.villepinte@gmail.com>

Makefile

smoench · 2020-12-04T09:34:33Z

@villfa Can you have a look at e2e_027 again? Still failing. Thanks in advance

villfa · 2020-12-04T09:50:48Z

Can you have a look at e2e_027 again? Still failing. Thanks in advance

Yes, I will, but I can't tell you when exactly. Probably this weekend.

villfa · 2020-12-04T13:41:12Z

The remaining error is not directly related to PHP 8.

Here some scoped code (generated with PHP 7.3):

if (!\function_exists('_PhpScoperd4c93190f897\\str_before')) {
    /**
     * Get the portion of a string before a given value.
     *
     * @param  string  $subject
     * @param  string  $search
     * @return string
     */
    function str_before($subject, $search)
    {
        return \_PhpScoperd4c93190f897\Illuminate\Support\Str::before($subject, $search);
    }
}
if (!\function_exists('str_contains')) {
    /**
     * Determine if a given string contains a given substring.
     *
     * @param  string  $haystack
     * @param  string|array  $needles
     * @return bool
     */
    function str_contains($haystack, $needles)
    {
        return \_PhpScoperd4c93190f897\Illuminate\Support\Str::contains($haystack, $needles);
    }
}

We see that str_contains has been treated as an internal function while this function doesn't exist before PHP 8.

A possible solution would be to take into account the @since annotation provided by phpstorm-stubs.

I'm not sure we want to fix this issue with this PR.

smoench · 2020-12-04T13:47:40Z

Well, this is more or less related to #440

villfa · 2020-12-07T08:59:14Z

@smoench e2e_027 is fixed with PHP8, and disabled with PHP7: smoench#1

theofidry · 2020-12-07T19:09:21Z

Regarding the Symfony & Laravel test suite: if those are the blockers in the CI I would ignore them. There is definitely issues with those two but they are more related to polyfill support and whether or not a symbol is considered as internal depending of the target PHP versions, which are two sets of problems to be addressed on their own

smoench · 2020-12-08T08:26:40Z

Ready for review 🚀

I also reworked the build workflow. It parallelized the e2e tests and is hopefully more readable.

smoench · 2020-12-08T08:29:26Z

A big thank you to @villfa. It was an honor to work with you on this!

theofidry

LGTM. Really impressed by the workflow it's really nice!

What is the issue about the pending build? Is it due to them being required by the branch in settings but no longer available?

smoench · 2020-12-08T08:52:21Z

Yes, the required builds are removed due to the rework and the settings needs to be updated.

theofidry · 2020-12-08T09:32:45Z

👌

theofidry · 2020-12-08T09:33:10Z

Thank you again @smoench @villfa for the amazing work

TomasVotruba · 2020-12-10T12:26:43Z

Hi, thank you for adding PHP 8!

It one of last blockers for Symplify packages, as we use scoper to release scoped PHP 8 packages.
Just curious, any ETA on release?

Thanks

smoench · 2020-12-21T11:59:36Z

@theofidry Can we have also a new release for php-scoper with PHP 8 support? Is there anything I can do to help you?

theofidry · 2020-12-21T14:35:49Z

https://github.com/humbug/php-scoper/releases/tag/0.14.0 released, sorry forgot about it :)

smoench · 2020-12-21T14:37:21Z

Thank you @theofidry 🚀

TomasVotruba · 2020-12-21T15:10:26Z

Thank you both!

smoench force-pushed the php8 branch 5 times, most recently from 061a4b5 to dbb8a3d Compare November 30, 2020 09:46

Add PHP 8 support

9162258

smoench force-pushed the php8 branch from dbb8a3d to 9162258 Compare November 30, 2020 09:54

upgrade covers-validator to version 1.3.1

f61aa68

smoench force-pushed the php8 branch from b35e40b to f61aa68 Compare November 30, 2020 14:49

enable pcov on PHP 8

a422a17

fix infection e2e test

27b55c7

smoench force-pushed the php8 branch from fa29d17 to 27b55c7 Compare December 1, 2020 10:43

smoench force-pushed the php8 branch from 76d360b to 383e782 Compare December 1, 2020 14:07

generate e2e jobs matrix

e39f00d

smoench force-pushed the php8 branch from 383e782 to e39f00d Compare December 1, 2020 14:09

villfa reviewed Dec 1, 2020

View reviewed changes

.github/workflows/e2e.yml Outdated Show resolved Hide resolved

villfa reviewed Dec 1, 2020

View reviewed changes

.github/workflows/generate-e2e-matrix.php Outdated Show resolved Hide resolved

smoench force-pushed the php8 branch 3 times, most recently from d586e7b to a4f3d76 Compare December 1, 2020 16:38

Update .github/workflows/e2e.yml

88653aa

Co-authored-by: Fabien Villepinte <fabien.villepinte@gmail.com>

smoench force-pushed the php8 branch from a4f3d76 to 88653aa Compare December 1, 2020 16:39

This was referenced Dec 2, 2020

php8 compatibility OskarStark/doctor-rst#842

Merged

Support PHP8 box-project/box#486

Closed

villfa and others added 2 commits December 3, 2020 19:16

Fix e2e_027

0bc797c

update nikic/php-parser

6b5ee73

villfa reviewed Dec 4, 2020

View reviewed changes

Makefile Outdated Show resolved Hide resolved

update composer for e2e_0210

70993b5

smoench force-pushed the php8 branch from 7e873d2 to 70993b5 Compare December 4, 2020 08:44

villfa and others added 3 commits December 8, 2020 08:51

Fix e2e_027 - 8.0

4168e98

Disable e2e_027 when PHP < 8

6751e54

rework build workflow

1738289

smoench force-pushed the php8 branch from ad63e67 to 1738289 Compare December 8, 2020 08:22

smoench marked this pull request as ready for review December 8, 2020 08:23

theofidry approved these changes Dec 8, 2020

View reviewed changes

theofidry merged commit 6ff13aa into humbug:master Dec 8, 2020

smoench deleted the php8 branch December 8, 2020 10:02

TomasVotruba mentioned this pull request May 8, 2021

php-scoper requires PHP 8 as minimum #449

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add PHP 8 support #446

Add PHP 8 support #446

smoench commented Nov 30, 2020 •

edited

Loading

smoench commented Nov 30, 2020

We generate the expected output file: we test that the scoping process

does not alter it

theofidry commented Nov 30, 2020

villfa commented Nov 30, 2020 •

edited

Loading

smoench commented Dec 1, 2020

smoench commented Dec 1, 2020

villfa commented Dec 1, 2020

smoench commented Dec 4, 2020

villfa commented Dec 4, 2020

villfa commented Dec 4, 2020

smoench commented Dec 4, 2020

villfa commented Dec 7, 2020

theofidry commented Dec 7, 2020

smoench commented Dec 8, 2020

smoench commented Dec 8, 2020

theofidry left a comment

smoench commented Dec 8, 2020

theofidry commented Dec 8, 2020

theofidry commented Dec 8, 2020

TomasVotruba commented Dec 10, 2020

smoench commented Dec 21, 2020

theofidry commented Dec 21, 2020

smoench commented Dec 21, 2020

TomasVotruba commented Dec 21, 2020

Add PHP 8 support #446

Add PHP 8 support #446

Conversation

smoench commented Nov 30, 2020 • edited Loading

smoench commented Nov 30, 2020

We generate the expected output file: we test that the scoping process

does not alter it

theofidry commented Nov 30, 2020

villfa commented Nov 30, 2020 • edited Loading

smoench commented Dec 1, 2020

smoench commented Dec 1, 2020

villfa commented Dec 1, 2020

smoench commented Dec 4, 2020

villfa commented Dec 4, 2020

villfa commented Dec 4, 2020

smoench commented Dec 4, 2020

villfa commented Dec 7, 2020

theofidry commented Dec 7, 2020

smoench commented Dec 8, 2020

smoench commented Dec 8, 2020

theofidry left a comment

Choose a reason for hiding this comment

smoench commented Dec 8, 2020

theofidry commented Dec 8, 2020

theofidry commented Dec 8, 2020

TomasVotruba commented Dec 10, 2020

smoench commented Dec 21, 2020

theofidry commented Dec 21, 2020

smoench commented Dec 21, 2020

TomasVotruba commented Dec 21, 2020

smoench commented Nov 30, 2020 •

edited

Loading

villfa commented Nov 30, 2020 •

edited

Loading