sync / Gateway development -> staging #373
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix / update dev version to 2.2.0
(fix) fix poll route for base approvals
(fix) change how PancakeSwap fetches V2 pools
Feat: Add sepolia values to uniswap tests
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const path = `${walletPath}/solana`; | ||
|
|
||
| const encryptedPrivateKey: string = await fse.readFile( | ||
| `${path}/${address}.json`, |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 6 days ago
To fix the problem, we need to validate the address parameter before using it to construct a file path. We can use the path module to ensure the constructed path is within a safe root directory. Specifically, we will:
- Normalize the constructed file path using
path.resolve. - Check that the normalized path starts with the root directory (
walletPath/solana).
Suggested changeset
1
src/chains/solana/solana.ts
| @@ -283,5 +283,9 @@ | ||
| const path = `${walletPath}/solana`; | ||
| const filePath = path.resolve(path, `${address}.json`); | ||
| if (!filePath.startsWith(path)) { | ||
| throw new Error('Invalid address path'); | ||
| } | ||
|
|
||
| const encryptedPrivateKey: string = await fse.readFile( | ||
| `${path}/${address}.json`, | ||
| filePath, | ||
| 'utf8' |
Copilot is powered by AI and may make mistakes. Always verify output.
(fix) solana tx
fix / solana tx costs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
Tests performed by the developer:
Tips for QA testing: