Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HT-8112: Merge upstream for EMR cluster #2

Merged
merged 49 commits into from
Aug 18, 2022
Merged

HT-8112: Merge upstream for EMR cluster #2

merged 49 commits into from
Aug 18, 2022

Conversation

LawrenceWarren
Copy link

Changes

  • Cutover to using CloudPosse Git history.
  • Add support for ALB's.

aknysh and others added 30 commits July 24, 2019 13:15
* Initial implementation

* Initial implementation

* Initial implementation

* Initial implementation

* Initial implementation

* Initial implementation

* Initial implementation

* Initial implementation

* Initial implementation

* Initial implementation

* Initial implementation

* Initial implementation

* Initial implementation

* Initial implementation

* Initial implementation

* Initial implementation

* Add `subnet_type` var

* Add `aws_vpc_endpoint` for private subnets

* Add `aws_vpc_endpoint` for private subnets

* Add `aws_vpc_endpoint` for private subnets

* Add `aws_vpc_endpoint` for private subnets

* Find `aws_route_table` by `subnet_id`

* Find `aws_route_table` by `subnet_id`

* Add `aws_route_table`

* Fix route table
* Use EMR default security groups for all managed security groups

* Use EMR default security groups for all managed security groups

* Use EMR default security groups for all managed security groups
…loudposse#11)

* Added application-autoscaling.amazonaws.com as Trusted entities for emr auto scaling role

Earlier autoscaling policy is failing to attach with the error
Failed to provision the AutoScaling policy: Unable to assume IAM role: arn:aws:iam::216727*****:role/emr-stage-dataorc-emr-ec2-autoscaling
this is due to absence of application-autoscaling.amazonaws.com as Trusted entity

* Ran terraform fmt

* corrected role for autosclaing policy, which requires 'elasticmapreduce.amazonaws.com', 'application-autoscaling.amazonaws.com' as trust entities

* New README.md generated from Package terraform-docs already installed
Generated README.md from /Users/navdeepagarwal/projects/open-projects/terraform-aws-emr-cluster/build-harness/templates/README.md using data from /Users/navdeepagarwal/projects/open-projects/terraform-aws-emr-cluster/build-harness/templates/README.yaml
* Add `slash-command-dispatch` GitHub Actions workflow

* random suffix added to name to avoid s3 bucket problems with existing buckets

* seed for rand applied

* test fixed

* test fixed

* Update examples/complete/fixtures.us-east-2.tfvars

Co-Authored-By: Erik Osterman <erik@cloudposse.com>

Co-authored-by: Erik Osterman <erik@cloudposse.com>
* Fix `log_uri` in example

Closes: cloudposse#8

* Updated README.md

Co-authored-by: Maxim Mironenko <simixido@gmail.com>
Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>
…rd is used in configuration_json (cloudposse#13)

* Add dummy bootstrap action that use md5 of configuration_json as an argument to prevent force recreation

* Terratest fixed, empty string as new default for configurations_json

* More descriptive comment for changes around bootstrap_action
…udposse#14)

* Add `var.create_vpc_endpoint_s3` to control S3 endpoint creation

* variable description

* Updated README.md

Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>
* Added kerberos_attributes configuration

* Readme updated
## What
* Adds chatops commands
  - '/test all'
  - '/test bats'
  - '/test readme'
  - '/test terratest'
* Drops codefresh
* Drops slash-command-dispatch
* Removes codefresh badge
* Rebuilds README

## Why
* Change over from codefresh to GH Actions
* Facilitate testing of PRs from forks
… 0.13 (cloudposse#19)

* [AUTOMATED] Update terraform-null-label versions to support Terraform 0.13

* Updated README.md

Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>
…udposse#18)

## What

1. Update Version Pinning for Terraform to support 0.13

## Why

1. This is a relatively minor update that the CloudPosse module already likely supports.
1. This allows module consumers to not individually update our Terraform module to support Terraform 0.13.
* fix: unquote references in ignore_changes

* Updated README.md

Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>
* Adding step concurrency level support

* Dropping rogue "

* dropping potentially confusing 'default is 1'

* Updated README.md

Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>
* fix: add ingress rule from managed master to service

* Make ingress rule consistent with other rules

* Join security groups ids, instead of using count

Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>

* Join security groups ids, instead of using count

Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>

* Updated README.md

Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>
…date GitHub Actions (cloudposse#28)

* Update to `context.tf`. Use the latest EMR version in the example. Update GitHub Actions

* Update to `context.tf`. Use the latest EMR version in the example. Update GitHub Actions
* Updating for issue number 7 so that we can include steps in the emr
cluster

* Executed 'terraform fmt'

* Updated README.md

Co-authored-by: Hannah Amundson <amundson.hannah@heb.com>
Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>
* update emr module to use existing security groups

* fix formatting & variable decription based on the review
Co-authored-by: osterman <osterman@users.noreply.github.com>
… to v0.12.0 (cloudposse#39)

Co-authored-by: Renovate Bot <bot@renovateapp.com>
* Add resource tags to created IAM roles

* Auto Format

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
* Feature: Allow users to pass their own IAM roles

* Rename variables following best practices

* update wording for variables & remove unused variable
mattbsea and others added 13 commits August 27, 2021 14:19
* feat: Added permissions boundary variables for iam roles

* feat: Add variable to adjust policy ARNs for use in AWS GovCloud.

* fix: type of govcloud set to bool instead of boolean

* Auto Format

* Auto Format

* partition

* Auto Format

* govcloud partition

* Update variables.tf

* Auto Format

Co-authored-by: nitrocode <nitrocode@users.noreply.github.com>
Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
…posse#48)

* chore(deps): update terraform cloudposse/label/null to v0.25.0

* Auto Format

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
* Upgrade aws provider to 3.0

* Auto Format

* Update versions.tf

* Update main.tf

* Update versions.tf

* Auto Format

Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
… to v0.12.2 (cloudposse#47)

* chore(deps): update terraform cloudposse/route53-cluster-hostname/aws to v0.12.2

* Auto Format

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
…e#54)

* Add missing tags to the aws_iam_instance_profile resource.

* Auto Format

Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
…dposse#55)

* Add support for auto termination policy

* Auto Format

* Fix null check

Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
* Clarify descriptions to indicate secgroup id is required

* Auto Format

Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
* git-xargs programmatic commit

* Auto Format

Co-authored-by: cloudpossebot <11232728+cloudpossebot@users.noreply.github.com>
…terns (cloudposse#57)

* Update all modules, examples and tests to the latest versions and patterns

* Update all modules, examples and tests to the latest versions and patterns

* Update all modules, examples and tests to the latest versions and patterns

* Update all modules, examples and tests to the latest versions and patterns

* Update all modules, examples and tests to the latest versions and patterns

* Update all modules, examples and tests to the latest versions and patterns

* Update all modules, examples and tests to the latest versions and patterns

* Update all modules, examples and tests to the latest versions and patterns

* Update all modules, examples and tests to the latest versions and patterns

* Update all modules, examples and tests to the latest versions and patterns

* Update all modules, examples and tests to the latest versions and patterns

* Update all modules, examples and tests to the latest versions and patterns

* Update all modules, examples and tests to the latest versions and patterns

* Update all modules, examples and tests to the latest versions and patterns

* Update all modules, examples and tests to the latest versions and patterns
Copy link

@Callumccr Callumccr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.gitignore Show resolved Hide resolved
@LawrenceWarren LawrenceWarren merged commit fb63dfd into master Aug 18, 2022
@LawrenceWarren LawrenceWarren deleted the HT-8112 branch August 18, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.