Merge branch 'next' into svelte-5-latest

huntabyte · Apr 12, 2024 · f11c5cd · f11c5cd
2 parents f5253d9 + 912601d
commit f11c5cd
Show file tree

Hide file tree

Showing 8 changed files with 24 additions and 20 deletions.
diff --git a/README.md b/README.md
@@ -25,7 +25,7 @@ This project is supported by the following beautiful people/organizations:
 
 <p align="center">
   <a href="https://github.com/sponsors/huntabyte">
-    <img src='https://cdn.jsdelivr.net/gh/huntabyte/static@main/sponsors.svg' alt="Logos from Sponsors" />
+    <img src='https://github.com/huntabyte/static/blob/main/sponsors.svg?raw=true' alt="Logos from Sponsors" />
   </a>
 </p>
 

diff --git a/packages/bits-ui/CHANGELOG.md b/packages/bits-ui/CHANGELOG.md
@@ -1,5 +1,11 @@
 # bits-ui
 
+## 0.21.3
+
+### Patch Changes
+
+- fix: toolbar onValueChange firing ([#448](https://github.com/huntabyte/bits-ui/pull/448))
+
 ## 0.21.2
 
 ### Patch Changes

diff --git a/packages/bits-ui/README.md b/packages/bits-ui/README.md
@@ -25,7 +25,7 @@ This project is supported by the following beautiful people/organizations:
 
 <p align="center">
   <a href="https://github.com/sponsors/huntabyte">
-    <img src='https://cdn.jsdelivr.net/gh/huntabyte/static@main/sponsors.svg' alt="Logos from Sponsors" />
+    <img src='https://github.com/huntabyte/static/blob/main/sponsors.svg?raw=true' alt="Logos from Sponsors" />
   </a>
 </p>
 

diff --git a/packages/bits-ui/package.json b/packages/bits-ui/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "bits-ui",
-	"version": "0.21.2",
+	"version": "0.21.3",
 	"license": "MIT",
 	"repository": "github:huntabyte/bits-ui",
 	"funding": "https://github.com/sponsors/huntabyte",

diff --git a/packages/bits-ui/src/lib/bits/toolbar/components/toolbar-group.svelte b/packages/bits-ui/src/lib/bits/toolbar/components/toolbar-group.svelte
@@ -2,6 +2,7 @@
 	import { melt } from "@melt-ui/svelte";
 	import { setGroupCtx } from "../ctx.js";
 	import type { GroupProps } from "../index.js";
+	import { arraysAreEqual } from "$lib/internal/arrays.js";
 
 	type T = $$Generic<"single" | "multiple">;
 	type $$Props = GroupProps<T>;
@@ -24,8 +25,11 @@
 		defaultValue: value,
 		onValueChange: (({ next }: { next: $$Props["value"] }) => {
 			if (Array.isArray(next)) {
-				onValueChange?.(next);
-				value = next;
+				if (!Array.isArray(value) || !arraysAreEqual(value, next)) {
+					onValueChange?.(next);
+					value = next;
+					return next;
+				}
 				return next;
 			}
 
@@ -39,7 +43,8 @@
 
 	const attrs = getAttrs("group");
 
-	$: value !== undefined && localValue.set(value);
+	$: value !== undefined &&
+		localValue.set(Array.isArray(value) ? ([...value] as $$Props["value"]) : (value as any));
 
 	$: updateOption("disabled", disabled);
 	$: updateOption("type", type);

diff --git a/packages/bits-ui/src/tests/toolbar/Toolbar.spec.ts b/packages/bits-ui/src/tests/toolbar/Toolbar.spec.ts
@@ -205,9 +205,6 @@ describe("toolbar", () => {
 			singleProps: { onValueChange: singleOnValueChange },
 		});
 
-		expect(newMultipleValue).toStrictEqual(["bold"]);
-		expect(newSingleValue).toBe(undefined);
-
 		await user.click(groupMultipleItemStrikethrough);
 		expect(newMultipleValue).toStrictEqual(["bold", "strikethrough"]);
 

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/sites/docs/svelte.config.js b/sites/docs/svelte.config.js
@@ -12,13 +12,13 @@ const __dirname = path.dirname(url.fileURLToPath(import.meta.url));
 const config = {
 	preprocess: [
 		mdsx(mdsxConfig),
-		vitePreprocess({
-			style: {
-				css: {
-					postcss: path.join(__dirname, "postcss.config.cjs"),
-				},
-			},
-		}),
+    vitePreprocess({
+      style: {
+        css: {
+            postcss: path.join(__dirname, "postcss.config.cjs"),
+          },
+        },
+    }),
 		preprocessMeltUI(),
 	],
 	extensions: [".svelte", ".md"],