Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix Alert Dialog closeOnOutsideClick default #294

Merged
merged 1 commit into from
Jan 25, 2024
Merged

docs: fix Alert Dialog closeOnOutsideClick default #294

merged 1 commit into from
Jan 25, 2024

Conversation

sebasmaltese
Copy link
Contributor

@sebasmaltese sebasmaltese commented Jan 23, 2024

The docs claim Alert Dialog's closeOnOutsideClick property is true by default but it is not:

export let closeOnOutsideClick: $$Props["closeOnOutsideClick"] = false;

I assume its behaving as intended, just like the radix primitives, so this PR just fixes the typo in the docs.

Copy link

changeset-bot bot commented Jan 23, 2024

⚠️ No Changeset found

Latest commit: 46b307c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bits-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2024 4:29am

Copy link
Owner

@huntabyte huntabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct. Thanks a ton!

@huntabyte huntabyte merged commit 54712ea into huntabyte:main Jan 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants