Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: menubar sub bug and update Melt UI to latest #309

Merged
merged 3 commits into from
Feb 4, 2024
Merged

fix: menubar sub bug and update Melt UI to latest #309

merged 3 commits into from
Feb 4, 2024

Conversation

huntabyte
Copy link
Owner

@huntabyte huntabyte commented Feb 4, 2024

Closes #307
Closes #304

This PR also updates Melt UI to the latest version which results in a multitude of small bug fixes regarding dialogs and menu performance. However, these updates introduce a breaking change to the Slider components.

The Slider.Root now exposes the thumbs and ticks slot props, each of which is an array of builders that must be passed to the Slider.Thumb and Slider.Tick components if being used.

<Slider.Root let:thumbs let:ticks>
	<!-- ... -->
	{#each thumbs as thumb}
		<Slider.Thumb {thumb} />
	{/each}

	{#each ticks as tick}
		<Slider.Tick {tick} />
	{/each}
	<!-- ... -->
</Slider.Root>

Copy link

changeset-bot bot commented Feb 4, 2024

🦋 Changeset detected

Latest commit: 3e77cab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
bits-ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bits-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2024 6:42pm

@huntabyte huntabyte merged commit efc0967 into main Feb 4, 2024
5 checks passed
@huntabyte huntabyte deleted the deps branch February 4, 2024 18:43
@github-actions github-actions bot mentioned this pull request Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menubar.Sub cannot be disabled Add support for vertical orientation and multiple handles in docs examples
1 participant