Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Forward click events from toolbar buttons and links #343

Merged
merged 10 commits into from
Feb 22, 2024

Conversation

fbbdev
Copy link
Contributor

@fbbdev fbbdev commented Feb 22, 2024

At present click events are not forwarded from toolbar buttons and links, making them pretty much useless except in render delegation mode.

Copy link

changeset-bot bot commented Feb 22, 2024

🦋 Changeset detected

Latest commit: 9ebf207

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
bits-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bits-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 22, 2024 6:18pm

Copy link
Owner

@huntabyte huntabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fbbdev
Copy link
Contributor Author

fbbdev commented Feb 22, 2024

Thanks!

You're welcome!

I updated the patch with typing information and some tests.

@huntabyte huntabyte merged commit 5a92cd7 into huntabyte:main Feb 22, 2024
5 checks passed
@github-actions github-actions bot mentioned this pull request Feb 22, 2024
@fbbdev fbbdev deleted the toolbar-fix branch February 22, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants