Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Button roundness is hardcoded by accident #1272

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jiu-virgil
Copy link

@jiu-virgil jiu-virgil commented Sep 16, 2024

Roundness was applied in base:

const buttonVariants = tv({
	base: 'rounded-md ring-offset-background focus-visible:ring-ring inline-flex items-center justify-center whitespace-nowrap text-sm font-medium transition-colors focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-offset-2 disabled:pointer-events-none disabled:opacity-50',
(...)

that means that it is applied to all variants, no matter the values of the size:

const buttonVariants = tv({
	base: '(...)',
	variants: {
		size: {
			sm: 'h-9 rounded-md px-3',
			lg: 'h-11 rounded-md px-8',
                        // (...)
		},
                // (...)
        },
        // (...)
});

I propose removing the rounded-md class from the base of the Button component

Roundness was applied every time, instead of being based on size.
Copy link

changeset-bot bot commented Sep 16, 2024

⚠️ No Changeset found

Latest commit: ea3372e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jiu-virgil jiu-virgil changed the title Fix: Button roundness is hardcoded by accident fix: Button roundness is hardcoded by accident Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant