Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli)(next): Add peerDependency precondition to CLI #1699

Merged
merged 12 commits into from
Feb 19, 2025

Conversation

ieedan
Copy link
Contributor

@ieedan ieedan commented Feb 17, 2025

Adds a check before running any of the commands to see if the supported versions of svelte and tailwindcss are being used if not it logs a warning.

Hopefully this will help with any confusion regarding support for tailwind v4.

Edit (Updated Preview):
image

Notes:

  • This does add a semver dependency but I think it's probably a net benefit. Maybe in the future this would allow me to open a PR to prevent installing dependencies when the user already has a newer version of a dependency.

@ieedan ieedan changed the title chore(cli): Add peerDependency precondition to CLI chore(cli)(next): Add peerDependency precondition to CLI Feb 17, 2025
Copy link

changeset-bot bot commented Feb 17, 2025

🦋 Changeset detected

Latest commit: d8d50b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
shadcn-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 17, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview 756033e

@ieedan
Copy link
Contributor Author

ieedan commented Feb 19, 2025

Thanks @AdrianGonz97!

Copy link
Collaborator

@AdrianGonz97 AdrianGonz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a great idea. Thank you!!

@AdrianGonz97 AdrianGonz97 merged commit 61d98fd into huntabyte:next Feb 19, 2025
6 checks passed
@ieedan
Copy link
Contributor Author

ieedan commented Feb 19, 2025

This was a great idea. Thank you!!

Sorry the implementation was so sloppy lol

@huntabyte
Copy link
Owner

Sorry the implementation was so sloppy lol

He makes me feel this way everytime he reviews my PRs too don't feel bad 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants