Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fix for building unit-tests for gtest itself with Mingw #10

Merged
merged 2 commits into from
Aug 28, 2016
Merged

Conversation

andoks
Copy link

@andoks andoks commented Aug 28, 2016

backport of bugfix for google#708 from upstream googletest.

fix #9

It's not supported, and native Windows threading is available for MinGW
@andoks
Copy link
Author

andoks commented Aug 28, 2016

@ruslo ruslo merged commit 714f92f into hunter-packages:hunter Aug 28, 2016
@ruslo
Copy link

ruslo commented Aug 29, 2016

https://ci.appveyor.com/project/andoks/googletest

Well, this test use Visual Studio:

-- Building for: Visual Studio 14 2015
-- The C compiler identification is MSVC 19.0.24213.1
-- The CXX compiler identification is MSVC 19.0.24213.1
-- Check for working C compiler using: Visual Studio 14 2015
-- Check for working C compiler using: Visual Studio 14 2015 -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler using: Visual Studio 14 2015
-- Check for working CXX compiler using: Visual Studio 14 2015 -- works

MinGW still not working:

I've saved this pull request in branch hunter.pr-10 and reverted hunter branch to the previous state.

@andoks
Copy link
Author

andoks commented Aug 30, 2016

Sorry, I'm not too familiar with appveyor, and obviously did not take enough time to set up building with MinGW properly.

It seems like even though the upstream PR was accepted, it still has not fixed all the issues with building with MinGW on windows (google#721).

An in addition, I'm still running with self-patched hunter (#8), and did not test the cherry-pick locally.

If I submit another PR, I'll make sure to set up testing properly with Appveyour.

@ruslo
Copy link

ruslo commented Aug 31, 2016

Here is the configuration with AppVeyor testing with MinGW: https://github.com/forexample/hunter-simple/blob/master/appveyor.yml. By the way you can send me pull request with working configuration (or may be even upstream).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

GTest fails to build with MinGW
3 participants