Update /open-debugger to try first target when unspecified (facebook#…

…39255) Summary: Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D48873336
huntie · Sep 4, 2023 · 87c6798 · 87c6798
1 parent 83885f1
commit 87c6798
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 14 deletions.
diff --git a/packages/dev-middleware/src/middleware/openDebuggerMiddleware.js b/packages/dev-middleware/src/middleware/openDebuggerMiddleware.js
@@ -50,19 +50,16 @@ export default function openDebuggerMiddleware({
       const {query} = url.parse(req.url, true);
       const {appId} = query;
 
-      if (typeof appId !== 'string') {
-        res.writeHead(400);
-        res.end();
-        eventReporter?.logEvent({
-          type: 'launch_debugger_frontend',
-          status: 'coded_error',
-          errorCode: 'MISSING_APP_ID',
-        });
-        return;
-      }
-
       const targets = await queryInspectorTargets(getDevServerUrl(req));
-      const target = targets.find(_target => _target.description === appId);
+      let target;
+
+      if (typeof appId === 'string') {
+        logger?.info('Launching JS debugger...');
+        target = targets.find(_target => _target.description === appId);
+      } else {
+        logger?.info('Launching JS debugger for first available target...');
+        target = targets[0];
+      }
 
       if (!target) {
         res.writeHead(404);
@@ -79,7 +76,6 @@ export default function openDebuggerMiddleware({
       }
 
       try {
-        logger?.info('Launching JS debugger...');
         await debuggerInstances.get(appId)?.kill();
         debuggerInstances.set(
           appId,

diff --git a/packages/dev-middleware/src/types/EventReporter.js b/packages/dev-middleware/src/types/EventReporter.js
@@ -37,7 +37,7 @@ export type ReportableEvent =
       ...
         | SuccessResult<{appId: string}>
         | ErrorResult<mixed>
-        | CodedErrorResult<'MISSING_APP_ID' | 'NO_APPS_FOUND'>,
+        | CodedErrorResult<'NO_APPS_FOUND'>,
     }
   | {
       type: 'connect_debugger_frontend',