Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support globally disabling memoization #13

Merged
merged 3 commits into from
Sep 14, 2024
Merged

Conversation

danielwestendorf
Copy link
Contributor

Fixes #11

Copy link
Collaborator

@scottjacobsen scottjacobsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jasonswett
Copy link

Might it not be confusing if someone is expecting memoization to be working in the test environment, but they discover that it's not, and they're not aware of .disable! so they don't know why?

This shouldn't be toggled on/off, used only for testing
@danielwestendorf danielwestendorf merged commit e63c950 into main Sep 14, 2024
4 checks passed
@danielwestendorf danielwestendorf deleted the global-disable branch September 14, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for disable TTLMemoization globally
3 participants