Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change version of kcov downloaded #64

Closed
wants to merge 2 commits into from
Closed

Change version of kcov downloaded #64

wants to merge 2 commits into from

Conversation

Kerollmops
Copy link

this could probably fix the issue #58

@autohuonw
Copy link
Collaborator

Thanks for the pull request, and welcome! You should hear from @huonw (or someone else) soon.

@Kerollmops
Copy link
Author

No, That don't fix anything...

@Kerollmops Kerollmops closed this Jan 5, 2017
@coveralls
Copy link

coveralls commented Jan 5, 2017

Coverage Status

Coverage increased (+9.6%) to 88.889% when pulling 77e7b50 on Kerollmops:master into af51893 on huonw:master.

@coveralls
Copy link

coveralls commented Jan 5, 2017

Coverage Status

Coverage increased (+9.6%) to 88.889% when pulling 77e7b50 on Kerollmops:master into af51893 on huonw:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+9.6%) to 88.889% when pulling 77e7b50 on Kerollmops:master into af51893 on huonw:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+9.6%) to 88.889% when pulling 77e7b50 on Kerollmops:master into af51893 on huonw:master.

@johanneskoester
Copy link

@Kerollmops I think this is still a good idea. For example, I get this error, which looks like kcov changed its command line arguments. Hence, I'd say going back to the version before the last travis-cargo release (v31) should make this work again and also maybe fix the upload problems.

@Kerollmops
Copy link
Author

Yup that's why I try to do but that just change nothing sadly 😞

@johanneskoester
Copy link

Can you say in what sense (what exactly is your error) and with which version? I thin v31 instead of v32 should help in this case.

@Kerollmops
Copy link
Author

I get the same error as you, I tried to change the kcov version but that change nothing...

@johanneskoester
Copy link

Did you change it to v31?

@Kerollmops
Copy link
Author

nope, but you can, just fork and test, if it work I am ready to see that ! 😄

@johanneskoester
Copy link

I have a fix in PR #66.

@Kerollmops
Copy link
Author

That's great, I subscribe to the thread !
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants