Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow views to move based on keyboard even when not having first responders #335

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dineshflock
Copy link

Goals 🥅

Currently keyboard binding only works if entry responds true for containsFirstResponder()
This PR will now allow consumers to create entries that are bound to Keyboard even when they have no first responders.

Implementation Details ✏️

Another case .bindAlways that can be used to bound an entry to Keyboards irrespective of firstResponder state.
Renamed old .bind case to .bindWhenResponder

Testing Details 🔍

Manually tested

TODO: Code as per repo conventions. Frankly I have not read the conventions. I will do once this PR seems eligible to be merged.

@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #335 (734ebe6) into master (cf1cde7) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #335      +/-   ##
=========================================
- Coverage    2.04%   2.04%   -0.01%     
=========================================
  Files          96      96              
  Lines        5472    5489      +17     
=========================================
  Hits          112     112              
- Misses       5360    5377      +17     
Impacted Files Coverage Δ
Source/Infra/EKContentView.swift 0.00% <0.00%> (ø)
...yAttributes/EKAttributes+PositionConstraints.swift 30.76% <0.00%> (-4.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf1cde7...734ebe6. Read the comment docs.

@murabye
Copy link

murabye commented Oct 18, 2021

I tried this, but when entry dissmissed, it dismiss without animation :(
And if keyboard is showed before entry, entry is on the back of the keyboard
Does anybody make a fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants