Add creation date info to missingInStorage case (#7523)

huridocs · Dec 4, 2024 · be44e62 · be44e62
1 parent 7540e85
commit be44e62
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 9 deletions.
diff --git a/app/api/files.v2/FilesHealthCheck.ts b/app/api/files.v2/FilesHealthCheck.ts
@@ -23,7 +23,11 @@ export class FilesHealthCheck {
   private onMissingInDBCB: (file: missingInDBFileDTO) => void = () => {};
 
   // eslint-disable-next-line class-methods-use-this
-  private onMissingInStorageCB: (fileDTO: { _id: string; filename: string }) => void = () => {};
+  private onMissingInStorageCB: (fileDTO: {
+    _id: string;
+    filename: string;
+    creationDate?: Date;
+  }) => void = () => {};
 
   private fileStorage: FileStorage;
 
@@ -59,7 +63,11 @@ export class FilesHealthCheck {
       if (!existsInStorage && !(file instanceof URLAttachment)) {
         counters.missingInStorage += 1;
         missingInStorageList.push(this.fileStorage.getPath(file));
-        this.onMissingInStorageCB({ _id: file.id, filename: file.filename });
+        this.onMissingInStorageCB({
+          _id: file.id,
+          filename: file.filename,
+          creationDate: file.creationDate,
+        });
       }
     });
 

diff --git a/app/api/files.v2/database/FilesMappers.ts b/app/api/files.v2/database/FilesMappers.ts
@@ -24,15 +24,15 @@ export const FileMappers = {
         fileDBO.entity,
         fileDBO.totalPages,
         fileDBO.url
-      );
+      ).withCreationDate(new Date(fileDBO.creationDate));
     }
     if (fileDBO.type === 'attachment') {
       return new Attachment(
         fileDBO._id.toString(),
         fileDBO.entity,
         fileDBO.totalPages,
         fileDBO.filename
-      );
+      ).withCreationDate(new Date(fileDBO.creationDate));
     }
 
     if (fileDBO.type === 'custom') {
@@ -41,13 +41,13 @@ export const FileMappers = {
         fileDBO.entity,
         fileDBO.totalPages,
         fileDBO.filename
-      );
+      ).withCreationDate(new Date(fileDBO.creationDate));
     }
     return new Document(
       fileDBO._id.toString(),
       fileDBO.entity,
       fileDBO.totalPages,
       fileDBO.filename
-    );
+    ).withCreationDate(new Date(fileDBO.creationDate));
   },
 };
diff --git a/app/api/files.v2/database/schemas/filesTypes.ts b/app/api/files.v2/database/schemas/filesTypes.ts
@@ -5,6 +5,7 @@ interface BaseFileDBOType {
   entity: string;
   filename: string;
   url: string;
+  creationDate: number;
 }
 
 interface DocumentFileDBOType extends BaseFileDBOType {

diff --git a/app/api/files.v2/model/BaseFile.ts b/app/api/files.v2/model/BaseFile.ts
@@ -5,9 +5,16 @@ export class BaseFile {
 
   readonly totalPages: number;
 
+  creationDate?: Date;
+
   constructor(id: string, entity: string, totalPages: number) {
     this.id = id;
     this.entity = entity;
     this.totalPages = totalPages;
   }
+
+  withCreationDate(date: Date) {
+    this.creationDate = date;
+    return this;
+  }
 }
diff --git a/app/api/files.v2/specs/FilesHealthCheck.spec.ts b/app/api/files.v2/specs/FilesHealthCheck.spec.ts
@@ -229,8 +229,12 @@ describe('FilesHealthCheck', () => {
 
   it('should be able to subscribe to an "event" for each file missing in storage', async () => {
     testStorageFiles = [];
+    const creationDate = Date.now();
     await testingEnvironment.setUp({
-      files: [factory.document('file1'), factory.document('file2')],
+      files: [
+        factory.document('file1', { creationDate }),
+        factory.document('file2', { creationDate }),
+      ],
     });
 
     const events: { _id: string; filename: string }[] = [];
@@ -240,8 +244,8 @@ describe('FilesHealthCheck', () => {
     await filesHealthCheck.execute();
 
     expect(events).toEqual([
-      { _id: factory.idString('file1'), filename: 'file1' },
-      { _id: factory.idString('file2'), filename: 'file2' },
+      { _id: factory.idString('file1'), filename: 'file1', creationDate: new Date(creationDate) },
+      { _id: factory.idString('file2'), filename: 'file2', creationDate: new Date(creationDate) },
     ]);
   });
 });