Unit tests #8
Merged
Unit tests #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 3, 2023 14:47
|
Thanks a lot for this, @MaximVanhove. I'll have a closer look over the weekend. I know we need the SVGs for the test, but I am not sure whether it is ok to include. I need to check the FontAwesome licenses: Is any of the SVG icons a pro icon? |
|
I had the same thought! So I made sure to only use free icons. The calculator icon and 500px icon are part of the free icon set. It doesn't really matter that it's an existing icon though. The path could be replaced with a custom icon. Maybe a logo for this package 🤔 |
|
It looks like the sharp icons are part of the pro icons, so I replaced them with a custom made icon. |
Merged
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @husseinalhammad
Here is a first draft of phpunit tests. This could be updated or refactored when adding FA6.
Please let me know what you think!