fix(jest-canvas-mock): improve constructor for dom matrix #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gentle ping. If this could be merged I could make my CI green 😄 |
|
@hustcc maybe you have time to review this one? It's really a one liner that will bring the mock closer to spec |
|
Ping! |
hustcc
approved these changes
Feb 5, 2024
|
Thanks! If you could publish a new version that would be great! |
Adamfsk
added a commit
to Adamfsk/jest-webgl-canvas-mock
that referenced
this pull request
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #117
This fixes the constructor so it can receive a DOMMatrix as arguments. That is to be in sync with the real constructor, in which
new DOMMatrix(new DOMMatrix(values))is totally valid.