Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(transform): slice transform on save, node 13 #52

Merged
merged 3 commits into from
Nov 4, 2019
Merged

fix(transform): slice transform on save, node 13 #52

merged 3 commits into from
Nov 4, 2019

Conversation

jtenner
Copy link
Collaborator

@jtenner jtenner commented Nov 4, 2019 •
edited
Loading

Apparently I don't have write access to the repo, but that's fine. I can submit pull requests like this.

Changes:

  • Add support for node 13
  • remove support for node 6 and 7
  • add slice to transform push (adds more memory usage but is compliant with spec
  • update babel env to target node 8
  • update node packages
  • cleanup changelog docs

Please check my work and publish at your convenience.

I didn't include the version bump to 2.2.0, but you should definitely do this when you're ready.

Fixes: #50
Fixes: #53

@jtenner jtenner added this to the 2.2.0 milestone Nov 4, 2019
@jtenner jtenner requested a review from hustcc November 4, 2019 14:45
@jtenner jtenner self-assigned this Nov 4, 2019
@coveralls
Copy link

coveralls commented Nov 4, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling fe6c6f0 on jtenner:transform-fix into d895824 on hustcc:master.

@jtenner jtenner mentioned this pull request Nov 4, 2019
Closed
@hustcc hustcc merged commit b836a8d into hustcc:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc Awaiting requested review from hustcc

Assignees

@jtenner jtenner

Labels
enhancement
Projects
None yet
Milestone
2.2.0
3 participants
@jtenner @coveralls @hustcc