-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code style enforcement, code of conduct #66
Conversation
Also, shouldn't we setup some travis/github action ci build processes? |
@@ -1,10 +1,10 @@ | |||
language: node_js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use github action?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just something to think about. Do you think it would be a good idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, GitHub action is excellent, but change to GitHub is not an emergency.
* [@hustcc](https://github.com/hustcc) | ||
* [@jtenner](https://github.com/jtenner) | ||
* [@evanoc0](https://github.com/evanoc0) | ||
- [@hustcc](https://github.com/hustcc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contributors all is here, https://github.com/hustcc/jest-canvas-mock/graphs/contributors
Maybe a table is more beautiful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can redo the contributors too. I just wanted to add the list to the readme. Is that okay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course that is okay!
@hustcc We should pull this before releasing 2.3.0.
Any thoughts?