Add translate, translateSelf, scale and scaleSelf to DOMMatrix #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtenner
requested changes
Aug 4, 2021
YonatanKra
changed the title
jtenner
reviewed
Aug 5, 2021
jtenner
reviewed
Aug 5, 2021
jtenner
reviewed
Aug 5, 2021
|
I just want another day to go over these changes. Thanks for the effort. |
The calculation function now deals with arrays instead of the properties directly
|
@hustcc I think this change is good enough. Could we release a minor version bump? |
|
@YonatanKra Thanks for your contribution. @jtenner Sorry for being late, I will release a new version soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.