Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(window): avoid global.window redefinition #91

Merged
merged 1 commit into from
Apr 28, 2022
Merged

fix(window): avoid global.window redefinition #91

merged 1 commit into from
Apr 28, 2022

Conversation

LitoMore
Copy link
Contributor

@LitoMore LitoMore commented Apr 20, 2022 •
edited
Loading

Changes

@LitoMore LitoMore mentioned this pull request Apr 20, 2022
Closed
langpavel
langpavel approved these changes Apr 21, 2022
View reviewed changes
Copy link

@langpavel langpavel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

hustcc
hustcc reviewed Apr 22, 2022
View reviewed changes
.github/workflows/main.yml Outdated Show resolved Hide resolved
hustcc
hustcc reviewed Apr 24, 2022
View reviewed changes
src/window.js Outdated Show resolved Hide resolved
@LitoMore LitoMore force-pushed the fix-redefine-window branch 2 times, most recently from a8a9776 to 81f1461 Compare April 28, 2022 05:45
@hustcc hustcc merged commit 505c62f into hustcc:master Apr 28, 2022
@LitoMore LitoMore deleted the fix-redefine-window branch April 28, 2022 09:12
@hustcc
Copy link
Owner

hustcc commented Apr 28, 2022

v2.4.0 released.

@LitoMore LitoMore mentioned this pull request May 7, 2022
Closed
@plainheart plainheart mentioned this pull request Apr 20, 2023
Merged
3 tasks
@SakshL SakshL mentioned this pull request Sep 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc hustcc left review comments

@langpavel langpavel langpavel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test fails on Node.js 18
3 participants
@LitoMore @hustcc @langpavel