Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "RECENT POSTS" display errors #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WeiChienHsu
Copy link

@WeiChienHsu WeiChienHsu commented Feb 8, 2019

Hi @huweihuang ,

Thanks for your contribution. I appreciate your effort and great talent of design.

RECENT POSTS

I found there is one issue on RECENT POSTS since the closing tag for the title was mistakenly assigned as h3 but starting with h5.

<h5><%= __('RECENT POSTS') %></h3>

Therefore, the UI has a little bit out of formatted like this:

image

By changing the closing tag, we can fix this bug:

image

I am not sure if someone else has faced this issue either.
Please help to make sure whether these changes are correct.

Thanks!


謝謝您對開源的貢獻,這是一個很棒的項目,也有著很漂亮的UI。
抓到一點小問題,希望日後能繼續參與優化,謝謝。


Update

FEATURED TAGS

When I generated two different tags with each of them has only one article.

image

There are no tags displayed on the sidebar.

image

After making this change to allow the tag with only featured-condition-size (1) also display on the sidebar, those two tags came back again!

image


不好意思,原本以為 FEATURE TAGS 沒有顯示出來,是自己設置出問題,
結果發現在 featured-tags.ejs 當中,原本預設

 <% if(tag.length > config['featured-condition-size']) { %>
            <a href="<%= config.root %>tags/#<%= tag.name %>" title="<%= tag.name %>" rel="<%= tag.length %>"><%= tag.name %></a>
            <% } %>

會將只有一篇文章的tag給隱藏,改成 >= 之後,就能將所有生成的tags顯示在home page了。


Kevin

In the RECENT POSTS sidebar, since the closing
tag was mistakely given as "h3", therefore, all
the unorder listed has been formatted as h5.
@WeiChienHsu WeiChienHsu changed the title 🔨 Fix the wrong closing tag on the sidebar "RECENT POSTS" Fix the wrong closing tag on the sidebar "RECENT POSTS" Feb 8, 2019
@WeiChienHsu WeiChienHsu changed the title Fix the wrong closing tag on the sidebar "RECENT POSTS" Fix "RECENT POSTS" and "FEATURED TAGS" display errors Feb 8, 2019
@huweihuang
Copy link
Owner

huweihuang commented Feb 11, 2019

@WeiChienHsu 你好,感谢你可以主动积极地参与该项目的bug修复,其中以下head标签没有规范,可以调整为一致,例如<h5>xxx</h5>,假如没有调整仍然是<h5>的标题效果,没有出现上述的格式问题。

<h5><%= __('RECENT POSTS') %></h3>

但是此处还是需要调整为一致比较好,即 你的第一个 commit 可以采纳:1c0c05b

2、关于featured-condition-size只需要在 _config.yml中将featured-condition-size参数设置为0 ,即可以解决当只有一篇文章时,feature tag仍可以显示,该commit 先不合并,你自己的项目如果要改也可以改成>=的方式。

3、 建议以后将不同的bug修复 分成不同的分支提交,方便合并独立的分支,比如我想合并你的第一个commit,但不想合并第二个commit,而你提成一个分支,我这边不方便合并,建议将第一个commit单独提一个分支给我,谢谢

4、另外issue中 有几个是明显的bug,目前还没有解决,如果你这边有时间也可以帮忙修复下,然后提个PR给我这边,谢谢

例如:

再次感谢你积极参与该项目的修复工作!

@WeiChienHsu WeiChienHsu force-pushed the fix-feature-RECENT-POSTS branch from a54c3ed to 1c0c05b Compare February 20, 2019 03:01
@WeiChienHsu
Copy link
Author

@huweihuang 謝謝您的回覆,不好意思這週在準備面試所以沒有及時回覆您。

但是此处还是需要调整为一致比较好,即 你的第一个 commit 可以采纳:1c0c05b

我已經使用 Interactive Rebase 將第二個 commit 移除,並且force-pushed回到這個branch,目前只留下第一個commit,您可以安心merge到master branch當中,謝謝。

3、 建议以后将不同的bug修复 分成不同的分支提交,方便合并独立的分支,比如我想合并你的第一个commit,但不想合并第二个commit,而你提成一个分支,我这边不方便合并,建议将第一个commit单独提一个分支给我,谢谢

謝謝您的建議,初次參與開源項目,之後會多加注意。

4、另外issue中 有几个是明显的bug,目前还没有解决,如果你这边有时间也可以帮忙修复下,然后提个PR给我这边,谢谢

下週面試完,我會開始著手維修一些Issues,到時再煩請協助通過code review.

@WeiChienHsu WeiChienHsu changed the title Fix "RECENT POSTS" and "FEATURED TAGS" display errors Fix "RECENT POSTS" display errors Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants