Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @huweihuang ,
Thanks for your contribution. I appreciate your effort and great talent of design.
RECENT POSTS
I found there is one issue on RECENT POSTS since the closing tag for the title was mistakenly assigned as h3 but starting with h5.
Therefore, the UI has a little bit out of formatted like this:
By changing the closing tag, we can fix this bug:
I am not sure if someone else has faced this issue either.
Please help to make sure whether these changes are correct.
Thanks!
謝謝您對開源的貢獻,這是一個很棒的項目,也有著很漂亮的UI。
抓到一點小問題,希望日後能繼續參與優化,謝謝。
Update
FEATURED TAGS
When I generated two different tags with each of them has only one article.
There are no tags displayed on the sidebar.
After making this change to allow the tag with only
featured-condition-size
(1) also display on the sidebar, those two tags came back again!不好意思,原本以為 FEATURE TAGS 沒有顯示出來,是自己設置出問題,
結果發現在
featured-tags.ejs
當中,原本預設會將只有一篇文章的tag給隱藏,改成
>=
之後,就能將所有生成的tags顯示在home page了。Kevin