Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint Python with ruff replacing bandit, flake8, isort, pyupgrade #149

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jul 11, 2023

Ruff supports over 500 lint rules and can be used to replace Flake8 (plus dozens of plugins), isort, pydocstyle, yesqa, eradicate, pyupgrade, and autoflake, all while executing (in Rust) tens or hundreds of times faster than any individual tool.

ruff --format=github . provides intuitive GitHub Annotations to contributors...

image

@hvlads
Copy link
Owner

hvlads commented Jul 30, 2023

Hi @cclauss ,

I wanted to express my personal appreciation for your exceptional work on integrating Ruff into our project and submitting the GitHub merge request. Your efforts have greatly improved our codebase, and as a fellow developer, I'm truly impressed by your contributions.

The consolidation of over 500 list rules and the performance boost Ref provides in Rust is remarkable. It demonstrates your deep understanding and expertise in improving code quality and development efficiency.

Thank you for your dedication and outstanding work! If you need any further support or have more ideas to improve our project, please don't hesitate to share.

Best regards,
Vladislav

@hvlads hvlads merged commit 7a8c0c1 into hvlads:master Jul 30, 2023
@cclauss cclauss deleted the ruff branch July 30, 2023 23:25
@cclauss
Copy link
Contributor Author

cclauss commented Jul 30, 2023

Thanks for your extremely kind words...

Given the migration not upgrade message, I am now trying to use a django-waffle flag to allow our QA Team and then our customers to toggle between the CKE4 and CKE5. I will let you know if I have any difficulties. Thanks massively for all your great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants