Fix specifying a spec in the cli args #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The custom spec wasn't getting the 'prefer-other' semantics of CFG#merge, so any spec specified by `--specification` in the args was getting ignored in favour of the default value of "Spec" from the base cfg. Fixed by leaving it as None by default and merging as `other.spec or self.spec`, moving the "Spec" fallback to the last possible moment (format_cfg)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom spec wasn't getting the 'prefer-other' semantics of CFG#merge, so any spec specified by
--specificationin the args was getting ignored in favour of the default value of "Spec" from the base cfg.Fixed by leaving it as None by default and merging as
other.spec or self.spec, moving the "Spec" fallback to the last possible moment (format_cfg)