Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update minimum serde version #68

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Update minimum serde version #68

merged 1 commit into from
Jun 20, 2023

Conversation

alex
Copy link
Contributor

@alex alex commented Jun 11, 2023

Without this, we cannot build with -Z minimal-versions

@alex
Copy link
Contributor Author

alex commented Jun 11, 2023

Failure doesn't look related

@complexspaces
Copy link
Collaborator

complexspaces commented Jun 11, 2023 •
edited
Loading

I agree. I'm trying to determine what the best course of action is so that these changes can land. The options I see are:

  • Bumping MSRV to 1.64 to match zbus's upcoming one
  • Restrict the versions of toml_datetime to <= 0.6.1
  • Simply merge this with after doing a manual clippy check and figure out MSRV later.

I'm leaning towards the second option, at least until zbus makes a new release with their higher MSRV. Do you or your affected project have any preference?

@alex
Copy link
Contributor Author

alex commented Jun 11, 2023

Adding something like https://github.com/sfackler/rust-openssl/pull/1808/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03fR79-R85 to the MSRV job is probably how I'd approach it.

@complexspaces
Copy link
Collaborator

Sorry for the delay. Do you mind rebasing this branch on master to pickup #70? I believe that should fix the unrelated problems here. Thank you for the pointers as well.

@alex
Update minimum serde version
ba77471 
Without this, we cannot build with `-Z minimal-versions`
@alex
Copy link
Contributor Author

alex commented Jun 19, 2023

Done

complexspaces
complexspaces approved these changes Jun 20, 2023
View reviewed changes
Copy link
Collaborator

@complexspaces complexspaces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With CI green now, this is good to go. Thanks again.

@complexspaces complexspaces merged commit 2df305b into hwchen:master Jun 20, 2023
@alex alex deleted the patch-1 branch June 20, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@complexspaces complexspaces complexspaces approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex @complexspaces