Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move MSRV testing to its own job #70

Merged
merged 2 commits into from
Jun 19, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 44 additions & 4 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ jobs:
matrix:
rust:
- stable
# MSRV, influenced by zbus.
- 1.60.0

steps:
- uses: actions/checkout@v2
Expand Down Expand Up @@ -76,8 +74,6 @@ jobs:
matrix:
rust:
- stable
# MSRV, influenced by zbus.
- 1.60.0

steps:
- uses: actions/checkout@v2
Expand All @@ -89,6 +85,14 @@ jobs:
toolchain: ${{ matrix.rust }}
profile: minimal

- uses: actions/cache@v2
with:
path: |
~/.cargo/registry
~/.cargo/git
target
key: $test-cache-${{ steps.toolchain.outputs.rustc_hash }}-${{ hashFiles('**/Cargo.lock') }}

- name: Install gnome-keyring
run: sudo apt-get install -y gnome-keyring

Expand Down Expand Up @@ -117,3 +121,39 @@ jobs:
with:
command: run
args: --features=rt-tokio-crypto-rust --example example

# MSRV, influenced by zbus.
check_msrv:
name: Check MSRV
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
with:
persist-credentials: false

- uses: actions-rs/toolchain@v1
with:
toolchain: "1.60.0"
profile: minimal

- uses: actions/cache@v2
with:
path: |
~/.cargo/registry
~/.cargo/git
target
key: $clippy-cache-${{ steps.toolchain.outputs.rustc_hash }}-${{ hashFiles('**/Cargo.lock') }}

- name: Generate lockfile
# XXX: `0.6.1` of `toml_datetime` is the last version with a MSRV that matches
# our current one.
run: |
cargo generate-lockfile
cargo update -p toml_datetime --precise "0.6.1"

- uses: actions-rs/cargo@v1
name: Clippy MSRV
with:
command: clippy
args: --features=rt-tokio-crypto-rust --all-targets --all -- -D clippy::dbg_macro -D warnings -F unused_must_use