Update zbus to v4 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this branch and it works correctly in my use case (https://github.com/VorpalBlade/chezmoi_modify_manager) but it seems like you need to fix some clippy warnings, as well as bump MSRV of this repo (probable locations this needs to be done: |
VorpalBlade
approved these changes
May 12, 2024
complexspaces
requested changes
Jun 7, 2024
There was a problem hiding this comment.
Thank you for working on this update. Do you mind rebasing this on master and updating the MSRV here to the lowest version that passes (I think zbus 4 is between 1.69 and 1.75)?
Once CI runs I think this looks good to go and can be the starting place for secret-service 4.0.
|
Released in v4.0.0 on crates.io. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71. The required changes seem to be pretty minor, unless there’s something I missed.