Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/TEST-1000-update-api #113

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Feature/TEST-1000-update-api #113

merged 2 commits into from
Jun 21, 2024

Conversation

hwinther
Copy link
Owner

Description 💬

Motivation and Context 🥅

How has this been tested? 🧪

  • Local build ⚒️
  • Local tests 🧪
  • (optional) Local run and endpoint tested in swagger 🚀

Screenshots (if appropriate) 💻

Types of changes 🌊

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist ☑️

  • The pull request title starts with the jira case number (when applicable), e.g. "TEST-1234 Add some feature"
  • The person responsible for following up on requested review changes has been assigned to the pull request
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Highly optional checks, only use these if you have a reason to do so ✔️

  • This PR changes the database so I have added the create-diagram label to assist reviewers with a db diagram
  • This PR changes platform or backend and I need others to be able to test against these changes before merging to dev, so I have added the deploy-azure label to deploy before merging the PR

Checklist for the approver ✅

  • I've checked the files view for spelling issues, code quality warnings and similar
  • I've waited until all checks have passed (green check/without error)
  • I've checked that only the intended files are changed

Copy link

✅ Build successful

Copy link

Todo Commenter

src/backend/WebApi/Entities/VersionInformation.cs
BUG
  • ","NET8"] Line: 16
src/backend/WebApi/swagger.json
BUG
  • ", Line: 412

@hwinther Please take a look 👀

Copy link

frontend

✅ Build successful

✅ No linting issues 🎊

Copy link

Summary

Summary
Generated on: 06/21/2024 - 21:49:22
Coverage date: 06/21/2024 - 21:49:20
Parser: MultiReport (2x Cobertura)
Assemblies: 1
Classes: 18
Files: 17
Line coverage: 5.6% (22 of 386)
Covered lines: 22
Uncovered lines: 364
Coverable lines: 386
Total lines: 912
Branch coverage: 0% (0 of 34)
Covered branches: 0
Total branches: 34
Method coverage: Feature is only available for sponsors

Coverage

WebApi - 5.6%
Name Line Branch
WebApi 5.6% 0%
Utils.Messaging.MessageReceiver 0% 0%
Utils.Messaging.MessageSender 0% 0%
Utils.Messaging.RabbitMqHelper 0% 0%
WebApi.Attributes.DefineConstantsAttribute 0%
WebApi.Blog 0%
WebApi.BloggingContext 100%
WebApi.Controllers.BloggingController 0%
WebApi.Controllers.SendMessageController 0%
WebApi.Controllers.ServiceController 0%
WebApi.Controllers.WeatherForecastController 100%
WebApi.Entities.BlogPostDto 0% 0%
WebApi.Entities.GenericValue`1 0%
WebApi.Entities.VersionInformation 0%
WebApi.Entities.WeatherForecast 100%
WebApi.Filters.ValidateModelAttribute 0% 0%
WebApi.Migrations.BloggingContextModelSnapshot 0%
WebApi.Migrations.InitialMigration 0%
WebApi.Post 0%

Copy link

Code Coverage

Package Line Rate Branch Rate Health
WebApi 6% 0%
Summary 6% (22 / 386) 0% (0 / 34)

@hwinther hwinther disabled auto-merge June 21, 2024 21:51
@hwinther hwinther merged commit e14694a into dev Jun 21, 2024
18 checks passed
@hwinther hwinther deleted the feature/TEST-1000-update-api branch June 21, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant