Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples #119

Merged
merged 12 commits into from
Jun 23, 2024
Merged

Add examples #119

merged 12 commits into from
Jun 23, 2024

Conversation

hwinther
Copy link
Owner

@hwinther hwinther commented Jun 22, 2024

Description 💬

Motivation and Context 🥅

How has this been tested? 🧪

  • Local build ⚒️
  • Local tests 🧪
  • (optional) Local run and endpoint tested in swagger 🚀

Screenshots (if appropriate) 💻

Types of changes 🌊

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist ☑️

  • The pull request title starts with the jira case number (when applicable), e.g. "TEST-1234 Add some feature"
  • The person responsible for following up on requested review changes has been assigned to the pull request
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Highly optional checks, only use these if you have a reason to do so ✔️

  • This PR changes the database so I have added the create-diagram label to assist reviewers with a db diagram
  • This PR changes platform or backend and I need others to be able to test against these changes before merging to dev, so I have added the deploy-azure label to deploy before merging the PR

Checklist for the approver ✅

  • I've checked the files view for spelling issues, code quality warnings and similar
  • I've waited until all checks have passed (green check/without error)
  • I've checked that only the intended files are changed

@hwinther hwinther marked this pull request as ready for review June 22, 2024 23:31
@hwinther hwinther enabled auto-merge (squash) June 22, 2024 23:31
Copy link

github-actions bot commented Jun 22, 2024

frontend

✅ Build successful

✅ No linting issues 🎊

Copy link

github-actions bot commented Jun 22, 2024

✅ Build successful

Copy link

github-actions bot commented Jun 22, 2024

Summary

Summary
Generated on: 06/23/2024 - 23:13:08
Coverage date: 06/23/2024 - 23:13:06
Parser: MultiReport (2x Cobertura)
Assemblies: 1
Classes: 26
Files: 25
Line coverage: 8.7% (66 of 752)
Covered lines: 66
Uncovered lines: 686
Coverable lines: 752
Total lines: 1701
Branch coverage: 11.2% (9 of 80)
Covered branches: 9
Total branches: 80
Method coverage: Feature is only available for sponsors

Coverage

WebApi - 8.7%
Name Line Branch
WebApi 8.7% 11.2%
WebApi.Attributes.DefineConstantsAttribute 0%
WebApi.Controllers.BloggingController 29.7% 12.5%
WebApi.Controllers.SendMessageController 0%
WebApi.Controllers.ServiceController 0%
WebApi.Controllers.WeatherForecastController 100%
WebApi.Database.Blog 0%
WebApi.Database.BlogConfiguration 100%
WebApi.Database.BloggingContext 100%
WebApi.Database.Post 0%
WebApi.Database.PostConfiguration 100%
WebApi.Entities.BlogDto 14.2% 0%
WebApi.Entities.GenericValue`1 0%
WebApi.Entities.PostDto 0% 0%
WebApi.Entities.VersionInformation 0%
WebApi.Entities.WeatherForecast 100%
WebApi.Filters.ValidateModelAttribute 0% 0%
WebApi.Messaging.MessageReceiver 0% 0%
WebApi.Messaging.MessageSender 0% 0%
WebApi.Messaging.RabbitMqHelper 0% 0%
WebApi.Middleware.ExceptionHandlingMiddleware 0% 0%
WebApi.Middleware.ProduceResponseTypeModelProvider 100% 100%
WebApi.Migrations.AddBlogMaxLength 0%
WebApi.Migrations.AddBlogTitleField 0%
WebApi.Migrations.BloggingContextModelSnapshot 0%
WebApi.Migrations.InitialMigration 0%
WebApi.Repository.BloggingRepository 0% 0%
success

Copy link

github-actions bot commented Jun 22, 2024

Code Coverage

Package Line Rate Branch Rate Health
WebApi 9% 11%
Summary 9% (66 / 752) 11% (9 / 80)

@hwinther hwinther disabled auto-merge June 23, 2024 12:39
@hwinther hwinther enabled auto-merge (squash) June 23, 2024 16:01
Copy link

Todo Commenter

.github/actions/frontend-build/action.yml
TODO:
  • ,FIXME:,BUG:" Line: 150
FIXME:
  • ,BUG:" Line: 150
BUG:
  • " Line: 150
.github/workflows/backend-ci.yml
TODO:
  • ,FIXME:,BUG:" Line: 122
  • set back to original once nunit is supported: dorny/test-reporter@v1 Line: 142
FIXME:
  • ,BUG:" Line: 122
BUG:
  • " Line: 122
tests/backend/WebApi.Tests/Controllers/BloggingControllerTests.cs
TODO:
  • Implement tests for the remaining actions using a similar pattern. Line: 86

@hwinther Please take a look 👀

@hwinther hwinther disabled auto-merge June 23, 2024 23:12
@hwinther hwinther merged commit b523087 into main Jun 23, 2024
9 of 10 checks passed
@hwinther hwinther deleted the feature/TEST-0003-add-examples branch June 23, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant